Mercurial > pidgin
changeset 13310:10c26505d6db
[gaim-migrate @ 15676]
Warn about prpls with preferences.
committer: Tailor Script <tailor@pidgin.im>
| author | Richard Laager <rlaager@wiktel.com> |
|---|---|
| date | Tue, 21 Feb 2006 19:55:55 +0000 |
| parents | 128324dcc821 |
| children | f6f465b8d1c0 |
| files | src/plugin.c |
| diffstat | 1 files changed, 19 insertions(+), 10 deletions(-) [+] |
line wrap: on
line diff
--- a/src/plugin.c Tue Feb 21 19:45:14 2006 +0000 +++ b/src/plugin.c Tue Feb 21 19:55:55 2006 +0000 @@ -448,17 +448,26 @@ return plugin; } - /* If plugin is a PRPL, make sure it implements the required functions */ - if ((plugin->info->type == GAIM_PLUGIN_PROTOCOL) && ( - (GAIM_PLUGIN_PROTOCOL_INFO(plugin)->list_icon == NULL) || - (GAIM_PLUGIN_PROTOCOL_INFO(plugin)->login == NULL) || - (GAIM_PLUGIN_PROTOCOL_INFO(plugin)->close == NULL))) + if (plugin->info->type == GAIM_PLUGIN_PROTOCOL) { - plugin->error = g_strdup(_("Plugin does not implement all required functions")); - gaim_debug_error("plugins", "%s is unloadable: Plugin does not implement all required functions\n", - plugin->path); - plugin->unloadable = TRUE; - return plugin; + /* If plugin is a PRPL, make sure it implements the required functions */ + if ((GAIM_PLUGIN_PROTOCOL_INFO(plugin)->list_icon == NULL) || + (GAIM_PLUGIN_PROTOCOL_INFO(plugin)->login == NULL) || + (GAIM_PLUGIN_PROTOCOL_INFO(plugin)->close == NULL)) + { + plugin->error = g_strdup(_("Plugin does not implement all required functions")); + gaim_debug_error("plugins", "%s is unloadable: Plugin does not implement all required functions\n", + plugin->path); + plugin->unloadable = TRUE; + return plugin; + } + + /* For debugging, let's warn about prpl prefs. */ + if (plugin->info->prefs_info != NULL) + { + gaim_debug_error("plugins", "%s has a prefs_info, but is a prpl. This is no longer supported.\n", + plugin->path); + } } return plugin;