changeset 28863:1182e604439c

*** Plucked rev 8549b9a30115559965e9bf93bb15a45b04c1d149 (f05c54b03e6bbfdbff38c01697fbd353a969e05e): certs: Cache certs once again (at the end of the verification process). It looks like I accidentally broke this (libpurple wouldn't replace a cert already in the cache) when extending the invalidity reasons.
author Daniel Atallah <daniel.atallah@gmail.com>
date Thu, 07 Jan 2010 23:46:24 +0000
parents bc4401ae1ab1
children a7f5aa182400
files ChangeLog libpurple/certificate.c
diffstat 2 files changed, 6 insertions(+), 3 deletions(-) [+]
line wrap: on
line diff
--- a/ChangeLog	Thu Jan 07 23:46:01 2010 +0000
+++ b/ChangeLog	Thu Jan 07 23:46:24 2010 +0000
@@ -2,6 +2,10 @@
 Pidgin and Finch: The Pimpin' Penguin IM Clients That're Good for the Soul
 
 version 2.6.5 (??/??/20??):
+	libpurple:
+	* TLS certificates are actually stored to the local cache once again
+	  (accepting a name mismatch on a certificate should now be remembered)
+
 	General:
 	* Build-time fixes for Solaris.  (Paul Townsend)
 
--- a/libpurple/certificate.c	Thu Jan 07 23:46:01 2010 +0000
+++ b/libpurple/certificate.c	Thu Jan 07 23:46:24 2010 +0000
@@ -1431,9 +1431,8 @@
 	tls_peers = purple_certificate_find_pool(x509_tls_cached.scheme_name,
 						 "tls_peers");
 	if (tls_peers) {
-		if (!purple_certificate_pool_contains(tls_peers, vrq->subject_name) &&
-		        !purple_certificate_pool_store(tls_peers,vrq->subject_name,
-		                                       peer_crt)) {
+		if (!purple_certificate_pool_store(tls_peers,vrq->subject_name,
+		                                   peer_crt)) {
 			purple_debug_error("certificate/x509/tls_cached",
 			                   "FAILED to cache peer certificate\n");
 		}