Mercurial > pidgin

changeset 28800:139aa186e8cc

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Don't call purple_xfer_start in msn_xfer_init. purple_xfer_start is called later after the other side accepts, and this second call clobbers the file handle. This file handle is leaked resulting in Pidgin appearing to lock the file stopping Windows from being able to delete it. The changes from darkrain42's branch actually fixed the real file handle leak except for the addition of this one line. Fixes #1643.
author Elliott Sales de Andrade <qulogic@pidgin.im>
date Mon, 14 Dec 2009 06:50:33 +0000
parents bcea7c92d3f1
children 19be6fe515ca 20f4bce8894d 3ad839deed75 a4c45a92938d
files ChangeLog libpurple/protocols/msn/slp.c
diffstat 2 files changed, 2 insertions(+), 2 deletions(-) [+]
line wrap: on
line diff
--- a/ChangeLog	Mon Dec 14 06:10:28 2009 +0000
+++ b/ChangeLog	Mon Dec 14 06:50:33 2009 +0000
@@ -11,6 +11,8 @@
 	MSN:
 	* File transfer requests will no longer cause a crash if you delete the file
 	  before the other side accepts.
+	* Recieved files will no longer hold an extra lock after completion, meaning
+	  they can be moved or deleted without complaints from your OS.
 
 	XMPP:
 	* Added support for the SCRAM-SHA-1 SASL mechanism.  This is only
--- a/libpurple/protocols/msn/slp.c	Mon Dec 14 06:10:28 2009 +0000
+++ b/libpurple/protocols/msn/slp.c	Mon Dec 14 06:50:33 2009 +0000
@@ -96,8 +96,6 @@
 
 	g_free(content);
 	msn_slplink_send_queued_slpmsgs(slpcall->slplink);
-
-	purple_xfer_start(xfer, -1, NULL, 0);
 }
 
 void