Mercurial > pidgin
changeset 2347:182a4f8b1333
[gaim-migrate @ 2360]
Sorry rob. I just don't think that you should be committing what you know is half-complete code, and allow users to access it. We can't be recommending to people to be using CVS instead of releases and then add things that we know beforehand are buggy or incomplete. Also I don't think that you've implemented it properly: More than just Oscar have buddy icons (though Jabber is reworking their buddy icon stuff) and so it shouldn't be protocol-specific like this; also it should apply to the aim_user and not the gaim_connection, and you should be able to set it while you're not online, which means it should go in the Modify Account dialog and not the Protocol Actions dialog, with an OPT_PROTO_BUDDY_ICON flag so that the dialog knows whether or not the buddy icon can be set.
Also, you broke -Wall.
committer: Tailor Script <tailor@pidgin.im>
| author | Eric Warmenhoven <eric@warmenhoven.org> |
|---|---|
| date | Sat, 22 Sep 2001 10:08:19 +0000 |
| parents | b1c1e3401e10 |
| children | dd5f18429dd9 |
| files | src/protocols/oscar/oscar.c |
| diffstat | 1 files changed, 0 insertions(+), 3 deletions(-) [+] |
line wrap: on
line diff
--- a/src/protocols/oscar/oscar.c Sat Sep 22 09:25:11 2001 +0000 +++ b/src/protocols/oscar/oscar.c Sat Sep 22 10:08:19 2001 +0000 @@ -2634,8 +2634,6 @@ if (!strcmp(act, "Set User Info")) { show_set_info(gc); - } else if (!strcmp(act, "Set Buddy Icon")) { - show_set_icon(gc); } else if (!strcmp(act, "Change Password")) { show_change_passwd(gc); } else if (!strcmp(act, "Confirm Account")) { @@ -2661,7 +2659,6 @@ GList *m = NULL; m = g_list_append(m, "Set User Info"); - m = g_list_append(m, "Set Buddy Icon"); m = g_list_append(m, NULL); m = g_list_append(m, "Change Password"); m = g_list_append(m, "Confirm Account");