Mercurial > pidgin

changeset 26232:1977e930ab03

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Make sure we free itmsurl when showing the info window for a buddy with an itunes music store url
author Mark Doliner <mark@kingant.net>
date Fri, 27 Mar 2009 09:48:25 +0000
parents c2042718eb4d
children dd55229f634a
files libpurple/protocols/msn/cmdproc.c libpurple/protocols/oscar/oscar.c
diffstat 2 files changed, 4 insertions(+), 2 deletions(-) [+]
line wrap: on
line diff
--- a/libpurple/protocols/msn/cmdproc.c	Fri Mar 27 09:44:36 2009 +0000
+++ b/libpurple/protocols/msn/cmdproc.c	Fri Mar 27 09:48:25 2009 +0000
@@ -117,8 +117,10 @@
 
 	servconn = cmdproc->servconn;
 
-	if (!servconn->connected)
+	if (!servconn->connected) {
+		/* TODO: Need to free trans */
 		return;
+	}
 
 	msn_history_add(cmdproc->history, trans);
 
--- a/libpurple/protocols/oscar/oscar.c	Fri Mar 27 09:44:36 2009 +0000
+++ b/libpurple/protocols/oscar/oscar.c	Fri Mar 27 09:48:25 2009 +0000
@@ -870,11 +870,11 @@
 		if (itmsurl) {
 			tmp = g_strdup_printf("<a href=\"%s\">%s</a>",
 								  itmsurl, message);
-			g_free(itmsurl);
 			g_free(message);
 			message = tmp;
 		}
 	}
+	g_free(itmsurl);
 
 	if (is_away && message) {
 		tmp = purple_str_sub_away_formatters(message, purple_account_get_username(account));