Mercurial > pidgin

changeset 31674:1d657ec53cdb

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
account: Move a normalization outside of the for loop
author Paul Aurich <paul@darkrain42.org>
date Mon, 20 Jun 2011 04:14:13 +0000
parents 84f72590a319
children 7eeaf38e27b0 5166e76265ae bb77a9ceca17
files libpurple/account.c
diffstat 1 files changed, 2 insertions(+), 2 deletions(-) [+]
line wrap: on
line diff
--- a/libpurple/account.c	Sat Jun 18 11:44:27 2011 +0000
+++ b/libpurple/account.c	Mon Jun 20 04:14:13 2011 +0000
@@ -3038,19 +3038,19 @@
 	g_return_val_if_fail(name != NULL, NULL);
 	g_return_val_if_fail(protocol_id != NULL, NULL);
 
+	who = g_strdup(purple_normalize(account, name));
 	for (l = purple_accounts_get_all(); l != NULL; l = l->next) {
 		account = (PurpleAccount *)l->data;
 		if (!purple_strequal(account->protocol_id, protocol_id))
 			continue;
 
-		who = g_strdup(purple_normalize(account, name));
 		if (purple_strequal(purple_normalize(account, purple_account_get_username(account)), who)) {
 			g_free(who);
 			return account;
 		}
-		g_free(who);
 	}
 
+	g_free(who);
 	return NULL;
 }