Mercurial > pidgin
changeset 15285:21509d8e4e70
[gaim-migrate @ 18075]
It appears that bye_cmd() can be reached with an MsnCmdProc whose data is NULL -- that is, which was for a switchboard which has been destroyed. This may be better as a simple
if (swboard == NULL) return;
but since the code doesn't have a check for it at present I thought a g_return_if_fail() would be better until someone who understands all the MSN internals can take a closer look at what's going on.
committer: Tailor Script <tailor@pidgin.im>
| author | Evan Schoenberg <evan.s@dreskin.net> |
|---|---|
| date | Thu, 04 Jan 2007 23:55:17 +0000 |
| parents | e8f8749e6182 |
| children | 96abd13cc0b3 |
| files | libgaim/protocols/msn/switchboard.c |
| diffstat | 1 files changed, 4 insertions(+), 0 deletions(-) [+] |
line wrap: on
line diff
--- a/libgaim/protocols/msn/switchboard.c Thu Jan 04 23:38:43 2007 +0000 +++ b/libgaim/protocols/msn/switchboard.c Thu Jan 04 23:55:17 2007 +0000 @@ -642,6 +642,10 @@ swboard = cmdproc->data; user = cmd->params[0]; + /* cmdproc->data is set to NULL when the switchboard is destroyed; + * we may get a bye shortly thereafter. */ + g_return_if_fail(swboard != NULL); + if (!(swboard->flag & MSN_SB_FLAG_IM) && (swboard->conv != NULL)) gaim_debug_error("msn_switchboard", "bye_cmd: helper bug\n");