changeset 21026:27c72bd82a81

We really don't need to display Blocked: status in the tooltip for every buddy in a contact on MSN.
author Stu Tomlinson <stu@nosnilmot.com>
date Sat, 27 Oct 2007 13:27:45 +0000
parents 61a87e02da29
children f9fd63586fcb
files libpurple/protocols/msn/msn.c
diffstat 1 files changed, 6 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/libpurple/protocols/msn/msn.c	Sat Oct 27 13:12:27 2007 +0000
+++ b/libpurple/protocols/msn/msn.c	Sat Oct 27 13:27:45 2007 +0000
@@ -617,7 +617,12 @@
 	 * XXX: blocked icon overlay isn't always accurate for MSN.
 	 * XXX: This can die as soon as purple_privacy_check() knows that
 	 * XXX: this prpl always honors both the allow and deny lists. */
-	if (user)
+	/* While the above comment may be strictly correct (the privacy API needs
+	 * rewriteing), purple_privacy_check() is going to be more accurate at
+	 * indicating whether a particular buddy is going to be able to message
+	 * you, which is the important information that this is trying to convey.
+	 */
+	if (full && user)
 	{
 		purple_notify_user_info_add_pair(user_info, _("Blocked"),
 									   ((user->list_op & (1 << MSN_LIST_BL)) ? _("Yes") : _("No")));