Mercurial > pidgin
changeset 25538:27e6ab4ff554
This should fix a sporadic crash? The behavior before was clearly wrong--
there's no need to check that body != NULL twice. This behavior should
be better... but this probably shouldn't be a g_return(), since we don't
control the data sent to us by the server it shouldn't be considered a
programming error if they fail to send us the "Completed" key
| author | Mark Doliner <mark@kingant.net> |
|---|---|
| date | Thu, 26 Feb 2009 08:14:24 +0000 |
| parents | fc615861c88c |
| children | 14b927f45ec5 |
| files | libpurple/protocols/myspace/myspace.c |
| diffstat | 1 files changed, 1 insertions(+), 1 deletions(-) [+] |
line wrap: on
line diff
--- a/libpurple/protocols/myspace/myspace.c Thu Feb 26 06:03:37 2009 +0000 +++ b/libpurple/protocols/myspace/myspace.c Thu Feb 26 08:14:24 2009 +0000 @@ -3112,8 +3112,8 @@ body = msim_msg_get_dictionary(reply, "body"); g_return_if_fail(body != NULL); completed = msim_msg_get_string(body, "Completed"); - g_return_if_fail(body != NULL); msim_msg_free(body); + g_return_if_fail(completed != NULL); if (!g_str_equal(completed, "True")) { purple_debug_info("msim_import_friends_cb",