Mercurial > pidgin
changeset 5124:2e78141ec1b5
[gaim-migrate @ 5487]
The change to gaim-remote.c let me compile again.
This fixes the proxy problems with AIM and ICQ.
Tha Problem:
AIM and ICQ accounts would get signed off when receiving large chunks of
data that spanned multiple TCP packets. For people with big buddy lists,
this meant you would get kicked offline as soon as you signed on (because
you buddy list would have to be sent in more than one TCP packet), for
other people, you would get kicked offline when receiving someone's buddy
icon.
The Solution:
I checked out about 20 CVS from different times and narrowed the commit
to between February 23rd and 27th. I then looked at the commit log
for src/protocols/oscar/conn.c between those days and looked for something
that might cause problems, and reverted it.
The Culprit:
Herman's commit on February 25, 2003. It fixed some initite lizooping
when connecting to oscar accounts in Windows.
http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/gaim/gaim/src/protocols/oscar/conn.c.diff?r1=1.17&r2=1.18
committer: Tailor Script <tailor@pidgin.im>
| author | Mark Doliner <mark@kingant.net> |
|---|---|
| date | Sun, 13 Apr 2003 22:19:43 +0000 |
| parents | 309a3c5c8e77 |
| children | 74139d2562f5 |
| files | src/gaim-remote.c src/protocols/oscar/conn.c |
| diffstat | 2 files changed, 3 insertions(+), 0 deletions(-) [+] |
line wrap: on
line diff
--- a/src/gaim-remote.c Sun Apr 13 15:28:29 2003 +0000 +++ b/src/gaim-remote.c Sun Apr 13 22:19:43 2003 +0000 @@ -25,6 +25,7 @@ #include <getopt.h> #include <unistd.h> #include <string.h> +#include <locale.h> #include "gaim-socket.h" void show_remote_usage(char *name)
--- a/src/protocols/oscar/conn.c Sun Apr 13 15:28:29 2003 +0000 +++ b/src/protocols/oscar/conn.c Sun Apr 13 22:19:43 2003 +0000 @@ -1000,6 +1000,8 @@ if (!(conn->status & AIM_CONN_STATUS_INPROGRESS)) return -1; + fcntl(conn->fd, F_SETFL, 0); + conn->status &= ~AIM_CONN_STATUS_INPROGRESS; if ((userfunc = aim_callhandler(sess, conn, AIM_CB_FAM_SPECIAL, AIM_CB_SPECIAL_CONNCOMPLETE)))