Mercurial > pidgin
changeset 14618:2f0b4d0de5bb
[gaim-migrate @ 17346]
Fix the argument GaimValue types in a handful of signal registrations. These
being wrong didn't matter to things that knew/guessed what their arguments
were (i.e. C functions) but did matter to things that needed to trust the
GaimValue type information for the types (i.e plugin loaders). I'm pretty sure
I got this all right, it matches the docs at least.
I still think there are a couple problems (namely the *-timestamp functions
returning a GAIM_TYPE_POINTER instead of a GAIM_TYPE_STRING) but these were
much more obvious.
committer: Tailor Script <tailor@pidgin.im>
| author | Etan Reisner <pidgin@unreliablesource.net> |
|---|---|
| date | Mon, 25 Sep 2006 06:01:12 +0000 |
| parents | 3df4aadebc20 |
| children | 6ff3eb035e08 |
| files | libgaim/ft.c libgaim/sound.c |
| diffstat | 2 files changed, 29 insertions(+), 28 deletions(-) [+] |
line wrap: on
line diff
--- a/libgaim/ft.c Mon Sep 25 03:35:02 2006 +0000 +++ b/libgaim/ft.c Mon Sep 25 06:01:12 2006 +0000 @@ -1183,41 +1183,41 @@ /* register signals */ gaim_signal_register(handle, "file-recv-accept", - gaim_marshal_VOID__POINTER, - NULL, 1, - gaim_value_new(GAIM_TYPE_SUBTYPE, GAIM_SUBTYPE_XFER)); + gaim_marshal_VOID__POINTER, NULL, 1, + gaim_value_new(GAIM_TYPE_SUBTYPE, + GAIM_SUBTYPE_XFER)); gaim_signal_register(handle, "file-send-accept", - gaim_marshal_VOID__POINTER, - NULL, 1, - gaim_value_new(GAIM_TYPE_POINTER, GAIM_SUBTYPE_XFER)); + gaim_marshal_VOID__POINTER, NULL, 1, + gaim_value_new(GAIM_TYPE_SUBTYPE, + GAIM_SUBTYPE_XFER)); gaim_signal_register(handle, "file-recv-start", - gaim_marshal_VOID__POINTER, - NULL, 1, - gaim_value_new(GAIM_TYPE_POINTER, GAIM_SUBTYPE_XFER)); + gaim_marshal_VOID__POINTER, NULL, 1, + gaim_value_new(GAIM_TYPE_SUBTYPE, + GAIM_SUBTYPE_XFER)); gaim_signal_register(handle, "file-send-start", - gaim_marshal_VOID__POINTER, - NULL, 1, - gaim_value_new(GAIM_TYPE_POINTER, GAIM_SUBTYPE_XFER)); + gaim_marshal_VOID__POINTER, NULL, 1, + gaim_value_new(GAIM_TYPE_SUBTYPE, + GAIM_SUBTYPE_XFER)); gaim_signal_register(handle, "file-send-cancel", - gaim_marshal_VOID__POINTER, - NULL, 1, - gaim_value_new(GAIM_TYPE_POINTER, GAIM_SUBTYPE_XFER)); + gaim_marshal_VOID__POINTER, NULL, 1, + gaim_value_new(GAIM_TYPE_SUBTYPE, + GAIM_SUBTYPE_XFER)); gaim_signal_register(handle, "file-recv-cancel", - gaim_marshal_VOID__POINTER, - NULL, 1, - gaim_value_new(GAIM_TYPE_POINTER, GAIM_SUBTYPE_XFER)); + gaim_marshal_VOID__POINTER, NULL, 1, + gaim_value_new(GAIM_TYPE_SUBTYPE, + GAIM_SUBTYPE_XFER)); gaim_signal_register(handle, "file-send-complete", - gaim_marshal_VOID__POINTER, - NULL, 1, - gaim_value_new(GAIM_TYPE_POINTER, GAIM_SUBTYPE_XFER)); + gaim_marshal_VOID__POINTER, NULL, 1, + gaim_value_new(GAIM_TYPE_SUBTYPE, + GAIM_SUBTYPE_XFER)); gaim_signal_register(handle, "file-recv-complete", - gaim_marshal_VOID__POINTER, - NULL, 1, - gaim_value_new(GAIM_TYPE_POINTER, GAIM_SUBTYPE_XFER)); + gaim_marshal_VOID__POINTER, NULL, 1, + gaim_value_new(GAIM_TYPE_SUBTYPE, + GAIM_SUBTYPE_XFER)); gaim_signal_register(handle, "file-recv-request", - gaim_marshal_VOID__POINTER, - NULL, 1, - gaim_value_new(GAIM_TYPE_POINTER, GAIM_SUBTYPE_XFER)); + gaim_marshal_VOID__POINTER, NULL, 1, + gaim_value_new(GAIM_TYPE_SUBTYPE, + GAIM_SUBTYPE_XFER)); } void
--- a/libgaim/sound.c Mon Sep 25 03:35:02 2006 +0000 +++ b/libgaim/sound.c Mon Sep 25 06:01:12 2006 +0000 @@ -103,7 +103,8 @@ gaim_marshal_BOOLEAN__INT_POINTER, gaim_value_new(GAIM_TYPE_BOOLEAN), 2, gaim_value_new(GAIM_TYPE_INT), - gaim_value_new(GAIM_TYPE_POINTER)); + gaim_value_new(GAIM_TYPE_SUBTYPE, + GAIM_SUBTYPE_ACCOUNT)); gaim_prefs_add_none("/core/sound"); gaim_prefs_add_bool("/core/sound/while_away", FALSE);