Mercurial > pidgin

changeset 17595:43be5361c4dc

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Get rid of the oscar time offset. This was an attempt at making sure the "online since" tooltip for buddies in your buddy list was accurate even if your clock was wrong. However, it completely falls apart if you're signed in from more than one location. So I'm taking it out completely. If anyone wants to figure out a way to determine the offset between your local computer clock and the real time using some feature of the oscar protocol then feel free. In the mean time I'm fine with telling people to freaking fix their clock. Fixes #698.
author Mark Doliner <mark@kingant.net>
date Mon, 11 Jun 2007 08:28:17 +0000
parents 6d3d7ee05b06
children 18b62b0fc253
files libpurple/protocols/oscar/oscar.c libpurple/protocols/oscar/oscar.h
diffstat 2 files changed, 4 insertions(+), 6 deletions(-) [+]
line wrap: on
line diff
--- a/libpurple/protocols/oscar/oscar.c	Mon Jun 11 01:02:18 2007 +0000
+++ b/libpurple/protocols/oscar/oscar.c	Mon Jun 11 08:28:17 2007 +0000
@@ -1825,9 +1825,8 @@
 		signon = time(NULL) - info->sessionlen;
 	if (!aim_sncmp(purple_account_get_username(account), info->sn)) {
 		purple_connection_set_display_name(gc, info->sn);
-		od->timeoffset = signon - purple_presence_get_login_time(presence);
-	}
-	purple_prpl_got_user_login_time(account, info->sn, signon - od->timeoffset);
+	}
+	purple_prpl_got_user_login_time(account, info->sn, signon);
 
 	/* Idle time stuff */
 	/* info->idletime is the number of minutes that this user has been idle */
@@ -2849,12 +2848,12 @@
 	g_free(tmp);
 
 	if (userinfo->present & AIM_USERINFO_PRESENT_ONLINESINCE) {
-		time_t t = userinfo->onlinesince - od->timeoffset;
+		time_t t = userinfo->onlinesince;
 		oscar_user_info_add_pair(user_info, _("Online Since"), purple_date_format_full(localtime(&t)));
 	}
 
 	if (userinfo->present & AIM_USERINFO_PRESENT_MEMBERSINCE) {
-		time_t t = userinfo->membersince - od->timeoffset;
+		time_t t = userinfo->membersince;
 		oscar_user_info_add_pair(user_info, _("Member Since"), purple_date_format_full(localtime(&t)));
 	}
 
--- a/libpurple/protocols/oscar/oscar.h	Mon Jun 11 01:02:18 2007 +0000
+++ b/libpurple/protocols/oscar/oscar.h	Mon Jun 11 08:28:17 2007 +0000
@@ -447,7 +447,6 @@
 	guint icontimer;
 	guint getblisttimer;
 	guint getinfotimer;
-	gint timeoffset;
 
 	struct {
 		guint maxwatchers; /* max users who can watch you */