Mercurial > pidgin
changeset 14357:4e14503b9bac
[gaim-migrate @ 17063]
Fix an assertion that fails for me about half the time
when I try to sign onto MSN.
Here's a backtrace, in case someone wants to look at this
more in depth:
#4 0x00002aaab203d857 in msn_object_new_from_string (str=0x2aaaac4f0860 "0")
at object.c:79
obj = (MsnObject *) 0x7fff2bc6efe0
tag = 0x2aaaac4f0861 ""
c = 0x100000001 <Address 0x100000001 out of bounds>
__PRETTY_FUNCTION__ = "msn_object_new_from_string"
#5 0x00002aaab203bf37 in nln_cmd (cmdproc=0xd84f30, cmd=0xcb1e10)
at notification.c:687
session = (MsnSession *) 0xd72e70
account = (GaimAccount *) 0x63c020
gc = (GaimConnection *) 0xd5d9b0
user = (MsnUser *) 0xcb1d90
msnobj = (MsnObject *) 0x2aaaacc127d9
clientid = 32767
state = 0xc97820 "NLN"
passport = 0xd65310 "lbdash@yahoo.com"
friendly = 0x2aaaac4f0860 "0"
#6 0x00002aaab202ff18 in msn_cmdproc_process_cmd (cmdproc=0xd84f30,
cmd=0xcb1e10) at cmdproc.c:313
cb = 0x2aaab203be63 <nln_cmd>
trans = (MsnTransaction *) 0x0
#7 0x00002aaab202ffbe in msn_cmdproc_process_cmd_text (cmdproc=0xd84f30,
command=0xe082b0 "NLN NLN lbdash@yahoo.com lbdash@yahoo.com 1073741856 0")
at cmdproc.c:335
No locals.
#8 0x00002aaab2032c06 in read_cb (data=0xd4e600, source=7,
cond=GAIM_INPUT_READ) at httpconn.c:380
httpconn = (MsnHttpConn *) 0xd4e600
servconn = (MsnServConn *) 0xd65360
session = (MsnSession *) 0xd72e70
buf = "HTTP/1.1 200 OK\r\nDate: Sun, 27 Aug 2006 21:29:58 GMT\r\nServer:
Microsoft-IIS/6.0\r\nX-Powered-By: ASP.N ET\r\nX-MSN-Messenger:
SessionID=26246177.8760; GW-IP=207.46.7.4\r\nContent-Length: 56\r\nContent-type:
ap"...
cur = 0xe082b0 "NLN NLN lbdash@yahoo.com lbdash@yahoo.com 1073741856 0"
end = 0xe082e8 ""
old_rx_buf = 0xe082b0 "NLN NLN lbdash@yahoo.com lbdash@yahoo.com
1073741856 0"
len = 285
cur_len = 56
result_msg = 0xe082b0 "NLN NLN lbdash@yahoo.com lbdash@yahoo.com
1073741856 0"
result_len = 56
error = 0
committer: Tailor Script <tailor@pidgin.im>
| author | Mark Doliner <mark@kingant.net> |
|---|---|
| date | Sun, 27 Aug 2006 21:36:52 +0000 |
| parents | 4ae3c2913c3e |
| children | fdf65b672b87 |
| files | libgaim/protocols/msn/object.c |
| diffstat | 1 files changed, 3 insertions(+), 1 deletions(-) [+] |
line wrap: on
line diff
--- a/libgaim/protocols/msn/object.c Sun Aug 27 21:26:33 2006 +0000 +++ b/libgaim/protocols/msn/object.c Sun Aug 27 21:36:52 2006 +0000 @@ -76,7 +76,9 @@ char *tag, *c; g_return_val_if_fail(str != NULL, NULL); - g_return_val_if_fail(!strncmp(str, "<msnobj ", 8), NULL); + + if (strncmp(str, "<msnobj ", 8)) + return NULL; obj = msn_object_new();