Mercurial > pidgin

changeset 19491:4f472eef762c

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
- TODO-whacking
author William Ehlhardt <williamehlhardt@gmail.com>
date Mon, 20 Aug 2007 03:00:31 +0000
parents 79dbe5fc2097
children 447470c8111a
files libpurple/plugins/ssl/ssl-gnutls.c
diffstat 1 files changed, 6 insertions(+), 7 deletions(-) [+]
line wrap: on
line diff
--- a/libpurple/plugins/ssl/ssl-gnutls.c	Mon Aug 20 02:49:47 2007 +0000
+++ b/libpurple/plugins/ssl/ssl-gnutls.c	Mon Aug 20 03:00:31 2007 +0000
@@ -361,8 +361,7 @@
 	return s;
 }
 
-/* Forward declarations are fun!
-   TODO: This is a stupid place for this */
+/* Forward declarations are fun! */
 static PurpleCertificate *
 x509_import_from_datum(const gnutls_datum_t dt, gnutls_x509_crt_fmt_t mode);
 
@@ -398,8 +397,7 @@
 		peer_certs = g_list_append(peer_certs, newcrt);
 	}
 
-	/* cert_list shouldn't need free()-ing */
-	/* TODO: double-check this */
+	/* cert_list doesn't need free()-ing */
 
 	return peer_certs;
 }
@@ -501,12 +499,13 @@
 	/* Next, we'll simply yank the entire contents of the file
 	   into memory */
 	/* TODO: Should I worry about very large files here? */
-	/* TODO: Error checking */
-	g_file_get_contents(filename,
+	g_return_val_if_fail(
+		g_file_get_contents(filename,
 			    &buf,
 			    &buf_sz,
 			    NULL      /* No error checking for now */
-		);
+		),
+		NULL);
 	
 	/* Load the datum struct */
 	dt.data = (unsigned char *) buf;