Mercurial > pidgin

changeset 12184:5cd2294127e8

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
[gaim-migrate @ 14486] SF Patch #1363103, Casey Harkins 'From the wiki: "Crash when Message Notification plugin is set to use the Urgent hint, when a message is queued by the new queuing code." XGetWMHints() is returning NULL on the hidden conversation window which holds the "queued" conversations. The man page says: "The XGetWMHints function reads the window manager hints and returns NULL if no WM_HINTS property was set on the window or returns a pointer to a XWMHints structure if it succeeds." This patch allocates it if its NULL. This might not be necessary, as setting the URGENT hint on an unmapped window is not really going to do anything. Probably too much explanation for a 2 line patch. :-)' committer: Tailor Script <tailor@pidgin.im>
author Richard Laager <rlaager@wiktel.com>
date Tue, 22 Nov 2005 00:18:28 +0000
parents 891aeb151590
children c42e2720fe7b
files plugins/notify.c
diffstat 1 files changed, 2 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/plugins/notify.c	Mon Nov 21 23:47:59 2005 +0000
+++ b/plugins/notify.c	Tue Nov 22 00:18:28 2005 +0000
@@ -515,6 +515,8 @@
 
 	hints = XGetWMHints(GDK_WINDOW_XDISPLAY(win->window->window),
 	                    GDK_WINDOW_XWINDOW(win->window->window));
+	if(!hints)
+		hints = XAllocWMHints();
 	if (add)
 		hints->flags |= XUrgencyHint;
 	else