changeset 21449:29b8b1c79aa8

merge of '64bb85d88261de930f9c987d2347b6babf8e7641' and 'd439540e82a3d5bdf17515f1eb6fa87bf7875027'
author Mark Doliner <mark@kingant.net>
date Mon, 12 Nov 2007 08:10:40 +0000
parents 7710a871fabf (diff) 64068864b964 (current diff)
children b068b2d146d1 cc0df68f6fa9
files
diffstat 1 files changed, 12 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/pidgin/gtkmain.c	Mon Nov 12 07:59:13 2007 +0000
+++ b/pidgin/gtkmain.c	Mon Nov 12 08:10:40 2007 +0000
@@ -195,6 +195,18 @@
 
 char *segfault_message;
 
+/*
+ * This signal handler shouldn't be touching this much stuff.
+ * It should just set a flag and return, and something else in
+ * Pidgin should monitor the flag to see if something needs to
+ * be done.  Because the signal handler interrupts the program,
+ * it could be called in the middle of adding a new connection
+ * to the list of connections, and then if we try to disconnect
+ * all connections it could lead to a crash because the linked
+ * list of connections could be in a weird state.  But, well,
+ * this signal handler probably isn't called very often, so it's
+ * not a big deal.
+ */
 static void
 sighandler(int sig)
 {