Mercurial > pidgin

changeset 20939:87742ec493b1

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
disapproval of revision '9af00415175d29e7e9227c383939d392ea0af499'
author Casey Harkins <charkins@pidgin.im>
date Mon, 15 Oct 2007 04:29:22 +0000
parents 5c849ee68659
children 128aca651b9a
files pidgin/gtkconv.c pidgin/gtkdocklet.c
diffstat 2 files changed, 13 insertions(+), 17 deletions(-) [+]
line wrap: on
line diff
--- a/pidgin/gtkconv.c	Mon Oct 15 04:13:16 2007 +0000
+++ b/pidgin/gtkconv.c	Mon Oct 15 04:29:22 2007 +0000
@@ -2853,6 +2853,9 @@
 		if (gtkconv != NULL && gtkconv->active_conv != conv)
 			continue;
 		if (gtkconv == NULL) {
+			if (!hidden_only ||
+					!purple_conversation_get_data(conv, "unseen-count"))
+				continue;
 			r = g_list_prepend(r, conv);
 			c++;
 		} else {
--- a/pidgin/gtkdocklet.c	Mon Oct 15 04:13:16 2007 +0000
+++ b/pidgin/gtkdocklet.c	Mon Oct 15 04:29:22 2007 +0000
@@ -145,22 +145,15 @@
 		if (ui_ops->set_tooltip) {
 			GString *tooltip_text = g_string_new("");
 			for (l = convs, count = 0 ; l != NULL ; l = l->next, count++) {
-				PurpleConversation *conv = (PurpleConversation *)l->data;
-				PidginConversation *gtkconv = PIDGIN_CONVERSATION(conv);
-
-				if (count == DOCKLET_TOOLTIP_LINE_LIMIT - 1) {
-					g_string_append(tooltip_text, _("Right-click for more unread messages...\n"));
-				} else if(gtkconv) {
-					g_string_append_printf(tooltip_text,
-						ngettext("%d unread message from %s\n", "%d unread messages from %s\n", gtkconv->unseen_count),
-						gtkconv->unseen_count,
-						gtk_label_get_text(GTK_LABEL(gtkconv->tab_label)));
-				} else {
-					g_string_append_printf(tooltip_text,
-						ngettext("%d unread message from %s\n", "%d unread messages from %s\n",
-						GPOINTER_TO_INT(purple_conversation_get_data(conv, "unseen-count"))),
-						GPOINTER_TO_INT(purple_conversation_get_data(conv, "unseen-count")),
-						purple_conversation_get_name(conv));
+				if (PIDGIN_IS_PIDGIN_CONVERSATION(l->data)) {
+					PidginConversation *gtkconv = PIDGIN_CONVERSATION((PurpleConversation *)l->data);
+					if (count == DOCKLET_TOOLTIP_LINE_LIMIT - 1)
+						g_string_append(tooltip_text, _("Right-click for more unread messages...\n"));
+					else
+						g_string_append_printf(tooltip_text,
+							ngettext("%d unread message from %s\n", "%d unread messages from %s\n", gtkconv->unseen_count),
+							gtkconv->unseen_count,
+							gtk_label_get_text(GTK_LABEL(gtkconv->tab_label)));
 				}
 			}
 
@@ -765,7 +758,7 @@
 			if (pending) {
 				GList *l = get_pending_list(1);
 				if (l != NULL) {
-					pidgin_conv_present_conversation((PurpleConversation *)l->data);
+					purple_conversation_present((PurpleConversation *)l->data);
 					g_list_free(l);
 				}
 			} else {