Mercurial > pidgin
changeset 8494:8a1421dcef60
[gaim-migrate @ 9229]
Fix a memleak when adding smiley themes and leave a note about
another possible leak.
committer: Tailor Script <tailor@pidgin.im>
| author | Mark Doliner <mark@kingant.net> |
|---|---|
| date | Wed, 24 Mar 2004 01:37:04 +0000 |
| parents | 244a49ab79ef |
| children | a88124e46fc6 |
| files | src/gtkprefs.c |
| diffstat | 1 files changed, 9 insertions(+), 1 deletions(-) [+] |
line wrap: on
line diff
--- a/src/gtkprefs.c Tue Mar 23 23:23:52 2004 +0000 +++ b/src/gtkprefs.c Wed Mar 24 01:37:04 2004 +0000 @@ -421,6 +421,11 @@ "<span size='smaller' foreground='dim grey'>%s</span>", theme->name, theme->author, theme->desc); gtk_list_store_append (smiley_theme_store, &iter); + + /* + * LEAK - Gentoo memprof thinks pixbuf is leaking here... but it + * looks like it should be ok to me. Anyone know what's up? --Mark + */ pixbuf = gdk_pixbuf_new_from_file(theme->icon, NULL); gtk_list_store_set(smiley_theme_store, &iter, @@ -452,6 +457,7 @@ #endif gchar *destdir; gchar *tail; + GtkTreePath *themepath = NULL; /* Just to be safe */ g_strchomp(path); @@ -489,7 +495,9 @@ #endif g_free(destdir); - theme_refresh_theme_list(); + themepath = theme_refresh_theme_list(); + if (themepath != NULL) + gtk_tree_path_free(themepath); } static void