Mercurial > pidgin

changeset 21056:9e45c28b4b2b

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Fix some leaking GtkSizeGroups.
author Daniel Atallah <daniel.atallah@gmail.com>
date Tue, 30 Oct 2007 04:28:31 +0000
parents a0b0f988667e
children 44a6eeaabd80
files pidgin/gtkpluginpref.c pidgin/gtkpounce.c pidgin/gtkprefs.c pidgin/gtksavedstatuses.c pidgin/gtkutils.c pidgin/plugins/contact_priority.c pidgin/plugins/gevolution/new_person_dialog.c pidgin/plugins/pidginrc.c pidgin/plugins/spellchk.c pidgin/plugins/xmppconsole.c
diffstat 10 files changed, 34 insertions(+), 3 deletions(-) [+]
line wrap: on
line diff
--- a/pidgin/gtkpluginpref.c	Tue Oct 30 03:24:07 2007 +0000
+++ b/pidgin/gtkpluginpref.c	Tue Oct 30 04:28:31 2007 +0000
@@ -255,5 +255,7 @@
 		}
 	}
 
+	g_object_unref(sg);
+
 	return ret;
 }
--- a/pidgin/gtkpounce.c	Tue Oct 30 03:24:07 2007 +0000
+++ b/pidgin/gtkpounce.c	Tue Oct 30 04:28:31 2007 +0000
@@ -685,6 +685,8 @@
 	gtk_widget_set_sensitive(dialog->play_sound_browse, FALSE);
 	gtk_widget_set_sensitive(dialog->play_sound_test,   FALSE);
 
+	g_object_unref(sg);
+
 	sg = gtk_size_group_new(GTK_SIZE_GROUP_VERTICAL);
 	gtk_size_group_add_widget(sg, dialog->open_win);
 	gtk_size_group_add_widget(sg, dialog->popup);
@@ -697,6 +699,9 @@
 	gtk_size_group_add_widget(sg, dialog->play_sound_browse);
 	gtk_size_group_add_widget(sg, dialog->play_sound_test);
 
+	g_object_unref(sg);
+	sg = NULL;
+
 	gtk_table_attach(GTK_TABLE(table), dialog->open_win,         0, 1, 0, 1,
 					 GTK_FILL, 0, 0, 0);
 	gtk_table_attach(GTK_TABLE(table), dialog->popup,            0, 1, 1, 2,
--- a/pidgin/gtkprefs.c	Tue Oct 30 03:24:07 2007 +0000
+++ b/pidgin/gtkprefs.c	Tue Oct 30 04:28:31 2007 +0000
@@ -956,6 +956,7 @@
 	g_list_free(names);
 
 	gtk_widget_show_all(ret);
+	g_object_unref(sg);
 	return ret;
 }
 
@@ -1131,7 +1132,7 @@
 	GtkWidget *ret;
 	GtkWidget *vbox, *hbox, *entry;
 	GtkWidget *table, *label, *auto_ip_checkbox, *ports_checkbox, *spin_button;
-	GtkWidget *warning, *proxy_button;
+	GtkWidget *warning = NULL, *proxy_button = NULL;
 	GtkSizeGroup *sg;
 	PurpleProxyInfo *proxy_info = NULL;
 
@@ -1194,6 +1195,8 @@
 	g_signal_connect(G_OBJECT(auto_ip_checkbox), "clicked",
 					 G_CALLBACK(pidgin_toggle_sensitive), table);
 
+	g_object_unref(sg);
+
 	vbox = pidgin_make_frame (ret, _("Ports"));
 	sg = gtk_size_group_new(GTK_SIZE_GROUP_HORIZONTAL);
 
@@ -1337,12 +1340,13 @@
 	}
 
 	gtk_widget_show_all(ret);
+	g_object_unref(sg);
 	/* Only hide table if not running gnome otherwise we hide the IP address table! */
 	if (!purple_running_gnome() && (proxy_info == NULL ||
 	    purple_proxy_info_get_type(proxy_info) == PURPLE_PROXY_NONE ||
 	    purple_proxy_info_get_type(proxy_info) == PURPLE_PROXY_USE_ENVVAR)) {
 		gtk_widget_hide(table);
-	} else {
+	} else if (purple_running_gnome()) {
 		gchar *path;
 		path = g_find_program_in_path("gnome-network-preferences");
 		if (path != NULL) {
@@ -1501,6 +1505,7 @@
 	pidgin_set_accessible_label (entry, label);
 
 	gtk_widget_show_all(ret);
+	g_object_unref(sg);
 	return ret;
 }
 #endif /*_WIN32*/
@@ -1942,6 +1947,7 @@
 	gtk_box_pack_start(GTK_BOX(hbox), button, FALSE, FALSE, 1);
 
 	gtk_widget_show_all(ret);
+	g_object_unref(sg);
 
 	return ret;
 }
@@ -2067,6 +2073,7 @@
 	}
 
 	gtk_widget_show_all(ret);
+	g_object_unref(sg);
 
 	return ret;
 }
--- a/pidgin/gtksavedstatuses.c	Tue Oct 30 03:24:07 2007 +0000
+++ b/pidgin/gtksavedstatuses.c	Tue Oct 30 04:28:31 2007 +0000
@@ -1292,6 +1292,7 @@
 					 G_CALLBACK(status_editor_ok_cb), dialog);
 
 	gtk_widget_show_all(win);
+	g_object_unref(sg);
 }
 
 
@@ -1621,6 +1622,7 @@
 	}
 
 	gtk_widget_show_all(win);
+	g_object_unref(sg);
 }
 
 
--- a/pidgin/gtkutils.c	Tue Oct 30 03:24:07 2007 +0000
+++ b/pidgin/gtkutils.c	Tue Oct 30 04:28:31 2007 +0000
@@ -2992,6 +2992,8 @@
 	}
 	va_end(args);
 
+	g_object_unref(sg);
+
 	return vbox;
 }
 
--- a/pidgin/plugins/contact_priority.c	Tue Oct 30 03:24:07 2007 +0000
+++ b/pidgin/plugins/contact_priority.c	Tue Oct 30 04:28:31 2007 +0000
@@ -157,6 +157,7 @@
 	gtk_box_pack_start(GTK_BOX(hbox), spin, FALSE, FALSE, 0);
 
 	gtk_widget_show_all(ret);
+	g_object_unref(sg);
 
 	return ret;
 }
--- a/pidgin/plugins/gevolution/new_person_dialog.c	Tue Oct 30 03:24:07 2007 +0000
+++ b/pidgin/plugins/gevolution/new_person_dialog.c	Tue Oct 30 04:28:31 2007 +0000
@@ -416,4 +416,6 @@
 
 	/* Show it. */
 	gtk_widget_show(dialog->win);
+	g_object_unref(sg);
+	g_object_unref(sg2);
 }
--- a/pidgin/plugins/pidginrc.c	Tue Oct 30 03:24:07 2007 +0000
+++ b/pidgin/plugins/pidginrc.c	Tue Oct 30 04:28:31 2007 +0000
@@ -509,6 +509,11 @@
 	                 G_CALLBACK(purplerc_reread), NULL);
 
 	gtk_widget_show_all(ret);
+
+	g_object_unref(labelsg);
+	g_object_unref(widgetsg);
+	g_object_unref(buttonsg);
+
 	return ret;
 }
 
--- a/pidgin/plugins/spellchk.c	Tue Oct 30 03:24:07 2007 +0000
+++ b/pidgin/plugins/spellchk.c	Tue Oct 30 04:28:31 2007 +0000
@@ -2341,6 +2341,8 @@
 #endif
 
 	gtk_widget_show_all(ret);
+	g_object_unref(sg);
+	g_object_unref(sg2);
 	return ret;
 }
 
--- a/pidgin/plugins/xmppconsole.c	Tue Oct 30 03:24:07 2007 +0000
+++ b/pidgin/plugins/xmppconsole.c	Tue Oct 30 04:28:31 2007 +0000
@@ -325,8 +325,9 @@
 	gtk_text_buffer_get_iter_at_offset(buffer, &iter, strstr(stanza, "</iq>") - stanza);
 	gtk_text_buffer_place_cursor(buffer, &iter);
 	g_free(stanza);
-       
+
 	gtk_widget_destroy(dialog);
+	g_object_unref(sg);
 
 }
 
@@ -483,6 +484,7 @@
 	g_free(stanza);
 
 	gtk_widget_destroy(dialog);
+	g_object_unref(sg);
 }
 
 static void message_clicked_cb(GtkWidget *w, gpointer nul)
@@ -619,6 +621,7 @@
 	g_free(stanza);
 
 	gtk_widget_destroy(dialog);
+	g_object_unref(sg);
 }
 
 static void