changeset 20114:a465779350aa

Clarified the meaning of PURPLE_REASON_NETWORK_ERROR and PURPLE_REASON_AUTHENTICATION_FAILED, and added PURPLE_REASON_AUTHENTICATION_IMPOSSIBLE. It's not fatal basically because none of the places in prpl-jabber that need it set wants_to_die --- should it be?
author Will Thompson <will.thompson@collabora.co.uk>
date Wed, 19 Sep 2007 11:39:42 +0000
parents 1cbda8e2b913
children a68d51d60177
files libpurple/connection.c libpurple/connection.h
diffstat 2 files changed, 11 insertions(+), 2 deletions(-) [+]
line wrap: on
line diff
--- a/libpurple/connection.c	Tue Sep 18 22:04:20 2007 +0000
+++ b/libpurple/connection.c	Wed Sep 19 11:39:42 2007 +0000
@@ -531,6 +531,7 @@
 	switch (reason)
 	{
 		case PURPLE_REASON_NETWORK_ERROR:
+		case PURPLE_REASON_AUTHENTICATION_IMPOSSIBLE:
 			return FALSE;
 		case PURPLE_REASON_AUTHENTICATION_FAILED:
 		case PURPLE_REASON_ENCRYPTION_ERROR:
--- a/libpurple/connection.h	Tue Sep 18 22:04:20 2007 +0000
+++ b/libpurple/connection.h	Wed Sep 19 11:39:42 2007 +0000
@@ -58,10 +58,18 @@
 /** Possible errors that can cause a connection to be closed. */
 typedef enum
 {
-	/** There was an error sending or receiving on the network socket. */
+	/** There was an error sending or receiving on the network socket, or
+	 *  there was some protocol error (such as the server sending malformed
+	 *  data).
+	 */
 	PURPLE_REASON_NETWORK_ERROR = 0,
-	/** The username or password was invalid. */
+	/** The username or password (or some other credential) was incorrect.
+	 */
 	PURPLE_REASON_AUTHENTICATION_FAILED,
+	/** libpurple doesn't speak any of the authentication methods the
+	 *  server offered.
+	 */
+	PURPLE_REASON_AUTHENTICATION_IMPOSSIBLE,
 	/** There was an error negotiating SSL on this connection, or encryption
 	 *  was unavailable and an account option was set to require it.
 	 */