changeset 24199:aa8ddc4e12af

GtkBlist: don't set the Urgent hint whenever a connection error occurs or is updated In principle, setting Urgent is a good idea, because the user can tell that an error has occurred. However, it winds up being repeatedly re-set every time an account tries and fails to reconnect, which is incredibly annoying. I think the right solution is to keep a set of accounts we've set urgent for, removing them from the set when they successfully connect. But not setting it at all is better than the current state.
author Will Thompson <will.thompson@collabora.co.uk>
date Sun, 28 Sep 2008 17:19:38 +0000
parents 3f4b6162995f
children e9094d59a4c2
files pidgin/gtkblist.c
diffstat 1 files changed, 0 insertions(+), 6 deletions(-) [+]
line wrap: on
line diff
--- a/pidgin/gtkblist.c	Sun Sep 28 08:05:07 2008 +0000
+++ b/pidgin/gtkblist.c	Sun Sep 28 17:19:38 2008 +0000
@@ -4663,8 +4663,6 @@
 {
 	PidginBuddyListPrivate *priv = PIDGIN_BUDDY_LIST_GET_PRIVATE(gtkblist);
 	gtk_container_add(GTK_CONTAINER(priv->error_scrollbook), dialog);
-
-	set_urgent();
 }
 
 static GtkWidget *
@@ -4811,7 +4809,6 @@
 		GTK_CONTAINER(priv->error_scrollbook), account);
 	pidgin_mini_dialog_set_description(PIDGIN_MINI_DIALOG(mini_dialog),
 		description);
-	set_urgent();
 }
 
 
@@ -4967,8 +4964,6 @@
 	gtk_widget_show_all(account_label);
 
 	update_signed_on_elsewhere_minidialog_title();
-
-	set_urgent();
 }
 
 static void
@@ -4994,7 +4989,6 @@
 	GtkContainer *c = GTK_CONTAINER(priv->signed_on_elsewhere->contents);
 	GtkWidget *label = find_child_widget_by_account(c, account);
 	gtk_widget_set_tooltip_text(label, description);
-	set_urgent();
 #endif
 }