changeset 30597:adce8f13a749

jabber: Set a connection display name even when using legacy auth Previously, the only place we were setting one was in the bind-result code path, so it was always NULL when doing legacy auth, but that causes issues with jabber_presence_fake_to_self, so let's just have a default init in jabber_stream_new(). Should Fixes #12499
author Paul Aurich <paul@darkrain42.org>
date Sun, 10 Oct 2010 16:42:30 +0000
parents 11cfc72c0330
children 58c919deda6c
files ChangeLog libpurple/protocols/jabber/jabber.c
diffstat 2 files changed, 7 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/ChangeLog	Sun Oct 10 05:41:57 2010 +0000
+++ b/ChangeLog	Sun Oct 10 16:42:30 2010 +0000
@@ -58,6 +58,8 @@
 	  is "gmail.com" or "googlemail.com" (it's also needed for Google
 	  Talk used for accounts on arbitrary domains not using Google Apps
 	  for Your Domain). (#a14153)
+	* Improved handling of adding oneself to your buddy list when using
+	  Non-SASL (legacy) authentication. (#12499)
 
 	Yahoo/Yahoo JAPAN:
 	* Stop doing unnecessary lookups of certain alias information.  This
--- a/libpurple/protocols/jabber/jabber.c	Sun Oct 10 05:41:57 2010 +0000
+++ b/libpurple/protocols/jabber/jabber.c	Sun Oct 10 16:42:30 2010 +0000
@@ -968,6 +968,11 @@
 	js->buddies = g_hash_table_new_full(g_str_hash, g_str_equal,
 			g_free, (GDestroyNotify)jabber_buddy_free);
 
+	/* This is overridden during binding, but we need it here
+	 * in case the server only does legacy non-sasl auth!.
+	 */
+	purple_connection_set_display_name(gc, user);
+
 	js->user_jb = jabber_buddy_find(js, user, TRUE);
 	g_free(user);
 	if (!js->user_jb) {