Mercurial > pidgin

changeset 24479:b68a672b645d

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Is it valid to use purple_timeout_remove() to remove a timer when you're inside the callback for that timer? I don't know, but I do know that it's valid to return FALSE to cancel the timer. And I think this is cleaner.
author Mark Doliner <mark@kingant.net>
date Tue, 25 Nov 2008 01:32:20 +0000
parents 88955b918197
children b2e4d88383a2
files libpurple/protocols/msn/soap.c
diffstat 1 files changed, 1 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/libpurple/protocols/msn/soap.c	Wed Nov 19 03:08:57 2008 +0000
+++ b/libpurple/protocols/msn/soap.c	Tue Nov 25 01:32:20 2008 +0000
@@ -113,8 +113,8 @@
 			&t);
 
 		if (g_hash_table_size(sess->soap_table) == 0) {
-			purple_timeout_remove(sess->soap_cleanup_handle);
 			sess->soap_cleanup_handle = 0;
+			return FALSE;
 		}
 	}