Mercurial > pidgin

changeset 22452:c2b9399d95b2

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
some memleak fixes from Andrew Gaul again: ==9002== 12 bytes in 1 blocks are definitely lost in loss record 19 of 229 ==9002== at 0x4006A6E: malloc (vg_replace_malloc.c:207) ==9002== by 0xA1CAF5: g_malloc (in /lib/libglib-2.0.so.0.1400.6) ==9002== by 0xA35348: g_strdup (in /lib/libglib-2.0.so.0.1400.6) ==9002== by 0x4FD826F: oscar_format_screenname (oscar.c:6227) ==9002== by 0x4FD0C46: purple_bosrights (oscar.c:3632) ==7413== 4 bytes in 1 blocks are definitely lost in loss record 3 of 233 ==7413== at 0x4004B22: calloc (vg_replace_malloc.c:397) ==7413== by 0xA1CA5D: g_malloc0 (in /lib/libglib-2.0.so.0.1400.6) ==7413== by 0x5018159: irc_dccsend_recv (dcc_send.c:116) ==7413== 98 bytes in 9 blocks are definitely lost in loss record 91 of 233 ==7413== at 0x4006A6E: malloc (vg_replace_malloc.c:207) ==7413== by 0x234888A: vasprintf (in /lib/libc-2.7.so) ==7413== by 0xA44996: g_vasprintf (in /lib/libglib-2.0.so.0.1400.6) ==7413== by 0xA35485: g_strdup_vprintf (in /lib/libglib-2.0.so.0.1400.6) ==7413== by 0xA354AA: g_strdup_printf (in /lib/libglib-2.0.so.0.1400.6) ==7413== by 0x45E68DB: purple_str_size_to_units (util.c:3320) ==7413== by 0x80A9D19: pidgin_xfer_dialog_update_xfer (gtkft.c:1058) committer: Ka-Hing Cheung <khc@hxbc.us>
author Andrew Gaul <andrew@gaul.org>
date Sun, 09 Mar 2008 21:34:32 +0000
parents ec8eddc93a7f
children 8460fd4c9b59
files libpurple/protocols/irc/dcc_send.c libpurple/protocols/oscar/oscar.c pidgin/gtkft.c
diffstat 3 files changed, 5 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/libpurple/protocols/irc/dcc_send.c	Sun Mar 09 19:17:35 2008 +0000
+++ b/libpurple/protocols/irc/dcc_send.c	Sun Mar 09 21:34:32 2008 +0000
@@ -135,7 +135,7 @@
 		
 		purple_xfer_set_end_fnc(xfer, irc_dccsend_recv_destroy);
 		purple_xfer_set_request_denied_fnc(xfer, irc_dccsend_recv_destroy);
-		purple_xfer_set_cancel_send_fnc(xfer, irc_dccsend_recv_destroy);
+		purple_xfer_set_cancel_recv_fnc(xfer, irc_dccsend_recv_destroy);
 		
 		purple_xfer_request(xfer);
 	}
--- a/libpurple/protocols/oscar/oscar.c	Sun Mar 09 19:17:35 2008 +0000
+++ b/libpurple/protocols/oscar/oscar.c	Sun Mar 09 21:34:32 2008 +0000
@@ -6230,6 +6230,7 @@
 	if (!aim_sncmp(purple_account_get_username(purple_connection_get_account(gc)), nick)) {
 		if (!flap_connection_getbytype(od, SNAC_FAMILY_ADMIN)) {
 			od->setnick = TRUE;
+			g_free(od->newsn);
 			od->newsn = g_strdup(nick);
 			aim_srv_requestnew(od, SNAC_FAMILY_ADMIN);
 		} else {
--- a/pidgin/gtkft.c	Sun Mar 09 19:17:35 2008 +0000
+++ b/pidgin/gtkft.c	Sun Mar 09 21:34:32 2008 +0000
@@ -1064,6 +1064,9 @@
 					   COLUMN_REMAINING, remaining_str,
 					   -1);
 
+	g_free(size_str);
+	g_free(remaining_str);
+
 	if (purple_xfer_is_completed(xfer))
 	{
 		GdkPixbuf *pixbuf;