Mercurial > pidgin

changeset 18630:ce3c8d30a200

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Hopefully fix a hella sporadic infinite loop bug in ICQ (and maybe AIM). Thanks to Vijay from meebo and wbadger from our trac for helping debug and track this down. Fixes #2078.
author Mark Doliner <mark@kingant.net>
date Tue, 24 Jul 2007 18:54:07 +0000
parents 1b032e320dbf
children 462737382c64 cf9dfbbe8cd6 7a5bf42aa8d1
files libpurple/protocols/oscar/family_locate.c
diffstat 1 files changed, 12 insertions(+), 12 deletions(-) [+]
line wrap: on
line diff
--- a/libpurple/protocols/oscar/family_locate.c	Tue Jul 24 06:58:30 2007 +0000
+++ b/libpurple/protocols/oscar/family_locate.c	Tue Jul 24 18:54:07 2007 +0000
@@ -636,13 +636,15 @@
 	 * Parse out the Type-Length-Value triples as they're found.
 	 */
 	for (curtlv = 0; curtlv < tlvcnt; curtlv++) {
+		guint16 type;
+		guint8 number, length;
 		int endpos;
-		guint16 type, length;
 
 		type = byte_stream_get16(bs);
-		length = byte_stream_get16(bs);
+		number = byte_stream_get8(bs);
+		length = byte_stream_get8(bs);
 
-		endpos = byte_stream_curpos(bs) + length;
+		endpos = byte_stream_curpos(bs) + MIN(length, byte_stream_empty(bs));
 
 		if (type == 0x0001) {
 			/*
@@ -815,34 +817,32 @@
 			 * has stored on the server.
 			 */
 			guint16 type2;
-			guint8 number, length2;
+			guint8 number2, length2;
 			int endpos2;
 
 			/*
 			 * Continue looping as long as we're able to read type2,
-			 * number, and length2.
+			 * number2, and length2.
 			 */
 			while (byte_stream_curpos(bs) + 4 <= endpos) {
 				type2 = byte_stream_get16(bs);
-				number = byte_stream_get8(bs);
+				number2 = byte_stream_get8(bs);
 				length2 = byte_stream_get8(bs);
 
-				endpos2 = byte_stream_curpos(bs) + length2;
+				endpos2 = byte_stream_curpos(bs) + MIN(length2, byte_stream_empty(bs));
 
 				switch (type2) {
 					case 0x0000: { /* This is an official buddy icon? */
 						/* This is always 5 bytes of "0x02 01 d2 04 72"? */
-						byte_stream_advance(bs, length2);
 					} break;
 
 					case 0x0001: { /* A buddy icon checksum */
-						if ((length2 > 0) && ((number == 0x00) || (number == 0x01))) {
+						if ((length2 > 0) && ((number2 == 0x00) || (number2 == 0x01))) {
 							g_free(outinfo->iconcsum);
-							outinfo->iconcsumtype = number;
+							outinfo->iconcsumtype = number2;
 							outinfo->iconcsum = byte_stream_getraw(bs, length2);
 							outinfo->iconcsumlen = length2;
-						} else
-							byte_stream_advance(bs, length2);
+						}
 					} break;
 
 					case 0x0002: { /* A status/available message */