changeset 28306:dfabdc9cce88

Fix a possible null-dereference and/or memory leak. Yes, another diagnosis by clang-analyzer.
author Sadrul Habib Chowdhury <imadil@gmail.com>
date Mon, 28 Sep 2009 17:41:56 +0000
parents 7e2e95508a3a
children 858d9563ee8c
files libpurple/protocols/yahoo/libymsg.c
diffstat 1 files changed, 4 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/libpurple/protocols/yahoo/libymsg.c	Mon Sep 28 17:39:33 2009 +0000
+++ b/libpurple/protocols/yahoo/libymsg.c	Mon Sep 28 17:41:56 2009 +0000
@@ -983,7 +983,10 @@
 	if( (pkt_type == YAHOO_PKT_TYPE_P2P) && (val_11 != yd->session_id) ) {
 		purple_debug_warning("yahoo","p2p: %s sent us message with wrong session id. Disconnecting p2p connection to peer\n", im ? im->from : "(im was null)");
 		/* remove from p2p connection lists, also calls yahoo_p2p_disconnect_destroy_data */
-		g_hash_table_remove(yd->peers, im->from);
+		if (im) {
+			g_hash_table_remove(yd->peers, im->from);
+			g_free(im);
+		}
 		return;
 	}