changeset 12457:e585695bc16b

[gaim-migrate @ 14766] sf patch #1375513, from Casey Harkin do not send passwords to debug output committer: Tailor Script <tailor@pidgin.im>
author Mark Doliner <mark@kingant.net>
date Mon, 12 Dec 2005 05:48:08 +0000
parents ca4021fe9a1c
children 8626cc8d0df9
files src/protocols/gg/gg.c src/protocols/msn/nexus.c
diffstat 2 files changed, 17 insertions(+), 11 deletions(-) [+]
line wrap: on
line diff
--- a/src/protocols/gg/gg.c	Mon Dec 12 05:46:29 2005 +0000
+++ b/src/protocols/gg/gg.c	Mon Dec 12 05:48:08 2005 +0000
@@ -653,8 +653,7 @@
 		goto exit_err;
 	}
 
-	gaim_debug_info("gg", "change_passwd: old=%s; p1=%s; token=%s\n",
-			cur, p1, info->token->id);
+	gaim_debug_info("gg", "Changing password\n");
 
 	/* XXX: this e-mail should be a pref... */
 	h = gg_change_passwd4(ggp_get_uin(account),
--- a/src/protocols/msn/nexus.c	Mon Dec 12 05:46:29 2005 +0000
+++ b/src/protocols/msn/nexus.c	Mon Dec 12 05:48:08 2005 +0000
@@ -112,7 +112,7 @@
 	MsnNexus *nexus;
 	MsnSession *session;
 	char *username, *password;
-	char *request_str;
+	char *request_str, *head, *tail;
 	char *buffer = NULL;
 	guint32 ctint;
 	size_t s;
@@ -133,18 +133,19 @@
 
 	ctint = strtoul((char *)g_hash_table_lookup(nexus->challenge_data, "ct"), NULL, 10) + 200;
 
-	request_str = g_strdup_printf(
+	head = g_strdup_printf(
 		"GET %s HTTP/1.1\r\n"
-		"Authorization: Passport1.4 OrgVerb=GET,OrgURL=%s,sign-in=%s,pwd=%s,"
+		"Authorization: Passport1.4 OrgVerb=GET,OrgURL=%s,sign-in=%s",
+		nexus->login_path,
+		(char *)g_hash_table_lookup(nexus->challenge_data, "ru"),
+		username);
+
+	tail = g_strdup_printf(
 		"lc=%s,id=%s,tw=%s,fs=%s,ru=%s,ct=%" G_GUINT32_FORMAT ",kpp=%s,kv=%s,ver=%s,tpf=%s\r\n"
 		"User-Agent: MSMSGS\r\n"
 		"Host: %s\r\n"
 		"Connection: Keep-Alive\r\n"
-		"Cache-Control: no-cache\r\n"
-		"\r\n",
-		nexus->login_path,
-		(char *)g_hash_table_lookup(nexus->challenge_data, "ru"),
-		username, password,
+		"Cache-Control: no-cache\r\n",
 		(char *)g_hash_table_lookup(nexus->challenge_data, "lc"),
 		(char *)g_hash_table_lookup(nexus->challenge_data, "id"),
 		(char *)g_hash_table_lookup(nexus->challenge_data, "tw"),
@@ -157,8 +158,14 @@
 		(char *)g_hash_table_lookup(nexus->challenge_data, "tpf"),
 		nexus->login_host);
 
-	gaim_debug_misc("msn", "Sending: {%s}\n", request_str);
+	buffer = g_strdup_printf("%s,pwd=XXXXXXXX,%s\r\n", head, tail);
+	request_str = g_strdup_printf("%s,pwd=%s,%s\r\n", head, password, tail);
 
+	gaim_debug_misc("msn", "Sending: {%s}\n", buffer);
+
+	g_free(buffer);
+	g_free(head);
+	g_free(tail);
 	g_free(username);
 	g_free(password);