Mercurial > pidgin

changeset 8332:f4a878d48254

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
[gaim-migrate @ 9056] Minor tweaks to the list box in the multi-field request dialogs so they work without a label and scrollbar (Pekka Riikonen) committer: Tailor Script <tailor@pidgin.im>
author Christian Hammond <chipx86@chipx86.com>
date Wed, 25 Feb 2004 19:34:26 +0000
parents 19c664c54ce5
children 85dbaac926a7
files COPYRIGHT ChangeLog src/gtkrequest.c src/request.c
diffstat 4 files changed, 7 insertions(+), 4 deletions(-) [+]
line wrap: on
line diff
--- a/COPYRIGHT	Wed Feb 25 05:29:04 2004 +0000
+++ b/COPYRIGHT	Wed Feb 25 19:34:26 2004 +0000
@@ -93,6 +93,7 @@
 David Raeman
 Etan Reisner
 Kristian Rietveld
+Pekka Riikonen
 Tim Ringenbach
 Andrew Rodland
 Neil Sanchala
--- a/ChangeLog	Wed Feb 25 05:29:04 2004 +0000
+++ b/ChangeLog	Wed Feb 25 19:34:26 2004 +0000
@@ -38,6 +38,8 @@
 	* Conversation placement by account now works correctly with both
 	  chats and IMs, and takes the Combine Chats and IMs option into
 	  consideration.
+	* Minor tweaks to the list box in the multi-field request dialogs
+	  so they work without a label and scrollbar (Pekka Riikonen)
 	* The Disconnect dialog no longer raises and gains focus each time
 	  a disconnected account is added (Ka-Hing Cheung)
 	* Added new MSN error codes and fixed an incorrect one (Stu Tomlinson)
--- a/src/gtkrequest.c	Wed Feb 25 05:29:04 2004 +0000
+++ b/src/gtkrequest.c	Wed Feb 25 19:34:26 2004 +0000
@@ -903,8 +903,8 @@
 	/* Create the scrolled window */
 	sw = gtk_scrolled_window_new(NULL, NULL);
 	gtk_scrolled_window_set_policy(GTK_SCROLLED_WINDOW(sw),
-								   GTK_POLICY_AUTOMATIC,
-								   GTK_POLICY_ALWAYS);
+				       GTK_POLICY_AUTOMATIC,
+				       GTK_POLICY_AUTOMATIC);
 	gtk_scrolled_window_set_shadow_type(GTK_SCROLLED_WINDOW(sw),
 										GTK_SHADOW_IN);
 	gtk_widget_show(sw);
@@ -1134,7 +1134,8 @@
 
 				type = gaim_request_field_get_type(field);
 
-				if (type != GAIM_REQUEST_FIELD_BOOLEAN)
+				if (type != GAIM_REQUEST_FIELD_BOOLEAN &&
+				    gaim_request_field_get_label(field))
 				{
 					char *text;
 
--- a/src/request.c	Wed Feb 25 05:29:04 2004 +0000
+++ b/src/request.c	Wed Feb 25 19:34:26 2004 +0000
@@ -806,7 +806,6 @@
 	GaimRequestField *field;
 
 	g_return_val_if_fail(id   != NULL, NULL);
-	g_return_val_if_fail(text != NULL, NULL);
 
 	field = gaim_request_field_new(id, text, GAIM_REQUEST_FIELD_LIST);