annotate HACKING @ 24745:0e8d91cdd63a

Change the msim_msg_clone_element() function to respect the "dynamic_name" flag when cloning elements. This fixes the bug where buddies didn't appear in their correct groups the first time you sign in. The problem is that msim_add_contact_from_server() doesn't have the username, so it calls msim_lookup_user() and clones the contact_info. The problem is that the cloned version of the contact_info points to dynamic names which are freed before we get the response from the user lookup. So msim_add_contact_from_server_cb() is called and based the contact_info, but the names in the contact_info point to freed memory, so we couldn't lookup the uid or the group.
author Mark Doliner <mark@kingant.net>
date Mon, 15 Dec 2008 04:08:31 +0000
parents d73ee2690376
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
16174
c95641c98e47 Let's just have HACKING point to Trac, okay?
Richard Laager <rlaager@wiktel.com>
parents:
diff changeset
1 For information on hacking on Pidgin, Finch, or libpurple, see:
c95641c98e47 Let's just have HACKING point to Trac, okay?
Richard Laager <rlaager@wiktel.com>
parents:
diff changeset
2 http://developer.pidgin.im