Mercurial > pidgin
annotate plugins/Makefile.am @ 12229:18f0dadb29cf
[gaim-migrate @ 14531]
SF Patch #1366481 from Michael Carlson
"The function gtk_smiley_tree_insert() in gtkimhtml.c is
using up (on my system) the most CPU of all the
functions in gaim whenever the preferences box is
opened (tested by opening the preferences box 50 times
and measuring with oprofile).
The function is called some 297 times each time the
prefs box is opened, and each time we call strlen() on
a (usually 3 or 4) character string to see if the
string is empty or not.
I've eliminated the unnecessary call to strlen by
checking the first element, and I've changed the while
{} loop to a do {} while loop, because since we return
if the string is empty at the beginning of the
function, the same check on the first iteration of the
loop is unnecessary.
I believe it's faster for every case, even if only by a
little bit."
I don't know how necessary this is, but it doesn't hurt and it doesn't negatively impact the readability of the code.
I also fixed an existing piece of code for which the compiler issued a warning.
committer: Tailor Script <tailor@pidgin.im>
| author | Richard Laager <rlaager@wiktel.com> |
|---|---|
| date | Sat, 26 Nov 2005 17:09:29 +0000 |
| parents | 9096f56b725f |
| children | a1e241dd50b6 |
| rev | line source |
|---|---|
| 11680 | 1 DIST_SUBDIRS = docklet gevolution gestures mono musicmessaging perl ssl tcl ticker |
| 8089 | 2 |
| 3 if BUILD_GEVOLUTION | |
| 4 GEVOLUTION_DIR = gevolution | |
| 5 endif | |
|
5205
fefad67de2c7
[gaim-migrate @ 5573]
Christian Hammond <chipx86@chipx86.com>
parents:
4687
diff
changeset
|
6 |
|
fefad67de2c7
[gaim-migrate @ 5573]
Christian Hammond <chipx86@chipx86.com>
parents:
4687
diff
changeset
|
7 if USE_PERL |
|
fefad67de2c7
[gaim-migrate @ 5573]
Christian Hammond <chipx86@chipx86.com>
parents:
4687
diff
changeset
|
8 PERL_DIR = perl |
|
fefad67de2c7
[gaim-migrate @ 5573]
Christian Hammond <chipx86@chipx86.com>
parents:
4687
diff
changeset
|
9 endif |
|
fefad67de2c7
[gaim-migrate @ 5573]
Christian Hammond <chipx86@chipx86.com>
parents:
4687
diff
changeset
|
10 |
| 6694 | 11 if USE_TCL |
| 12 TCL_DIR = tcl | |
| 13 endif | |
| 14 | |
|
11435
1a2eaba2bc13
[gaim-migrate @ 13672]
Gary Kramlich <grim@reaperworld.com>
parents:
11405
diff
changeset
|
15 if ENABLE_DBUS |
|
1a2eaba2bc13
[gaim-migrate @ 13672]
Gary Kramlich <grim@reaperworld.com>
parents:
11405
diff
changeset
|
16 DBUS_LTLIB = dbus-example.la |
|
1a2eaba2bc13
[gaim-migrate @ 13672]
Gary Kramlich <grim@reaperworld.com>
parents:
11405
diff
changeset
|
17 |
|
1a2eaba2bc13
[gaim-migrate @ 13672]
Gary Kramlich <grim@reaperworld.com>
parents:
11405
diff
changeset
|
18 # Only use music messaging if dbus is enabled |
|
1a2eaba2bc13
[gaim-migrate @ 13672]
Gary Kramlich <grim@reaperworld.com>
parents:
11405
diff
changeset
|
19 MUSICMESSAGING_DIR = musicmessaging |
|
1a2eaba2bc13
[gaim-migrate @ 13672]
Gary Kramlich <grim@reaperworld.com>
parents:
11405
diff
changeset
|
20 endif |
|
1a2eaba2bc13
[gaim-migrate @ 13672]
Gary Kramlich <grim@reaperworld.com>
parents:
11405
diff
changeset
|
21 |
|
11660
a3302d271199
[gaim-migrate @ 13945]
Gary Kramlich <grim@reaperworld.com>
parents:
11621
diff
changeset
|
22 if USE_MONO |
|
a3302d271199
[gaim-migrate @ 13945]
Gary Kramlich <grim@reaperworld.com>
parents:
11621
diff
changeset
|
23 MONO_DIR = mono |
|
a3302d271199
[gaim-migrate @ 13945]
Gary Kramlich <grim@reaperworld.com>
parents:
11621
diff
changeset
|
24 endif |
|
a3302d271199
[gaim-migrate @ 13945]
Gary Kramlich <grim@reaperworld.com>
parents:
11621
diff
changeset
|
25 |
| 8089 | 26 SUBDIRS = \ |
|
11621
e0a61622a9f2
[gaim-migrate @ 13896]
Gary Kramlich <grim@reaperworld.com>
parents:
11592
diff
changeset
|
27 docklet \ |
|
e0a61622a9f2
[gaim-migrate @ 13896]
Gary Kramlich <grim@reaperworld.com>
parents:
11592
diff
changeset
|
28 $(GEVOLUTION_DIR) \ |
|
e0a61622a9f2
[gaim-migrate @ 13896]
Gary Kramlich <grim@reaperworld.com>
parents:
11592
diff
changeset
|
29 gestures \ |
| 11862 | 30 $(MONO_DIR) \ |
| 31 $(MUSICMESSAGING_DIR) \ | |
|
11621
e0a61622a9f2
[gaim-migrate @ 13896]
Gary Kramlich <grim@reaperworld.com>
parents:
11592
diff
changeset
|
32 $(PERL_DIR) \ |
|
e0a61622a9f2
[gaim-migrate @ 13896]
Gary Kramlich <grim@reaperworld.com>
parents:
11592
diff
changeset
|
33 ssl \ |
|
e0a61622a9f2
[gaim-migrate @ 13896]
Gary Kramlich <grim@reaperworld.com>
parents:
11592
diff
changeset
|
34 $(TCL_DIR) \ |
| 11862 | 35 ticker |
| 3391 | 36 |
|
4202
59751fe608c5
[gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents:
4104
diff
changeset
|
37 plugindir = $(libdir)/gaim |
|
59751fe608c5
[gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents:
4104
diff
changeset
|
38 |
| 10889 | 39 extplacement_la_LDFLAGS = -module -avoid-version $(GLIB_LIBS) |
| 40 gaimrc_la_LDFLAGS = -module -avoid-version $(GTK_LIBS) | |
| 41 history_la_LDFLAGS = -module -avoid-version $(GTK_LIBS) | |
| 42 iconaway_la_LDFLAGS = -module -avoid-version $(GTK_LIBS) | |
| 43 idle_la_LDFLAGS = -module -avoid-version $(GLIB_LIBS) | |
| 44 notify_la_LDFLAGS = -module -avoid-version $(GTK_LIBS) | |
| 45 relnot_la_LDFLAGS = -module -avoid-version $(GLIB_LIBS) | |
| 46 spellchk_la_LDFLAGS = -module -avoid-version $(GTK_LIBS) | |
| 47 statenotify_la_LDFLAGS = -module -avoid-version $(GLIB_LIBS) | |
| 48 timestamp_la_LDFLAGS = -module -avoid-version $(GTK_LIBS) | |
|
4202
59751fe608c5
[gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents:
4104
diff
changeset
|
49 |
|
11893
85c0aece7be9
[gaim-migrate @ 14184]
Gary Kramlich <grim@reaperworld.com>
parents:
11862
diff
changeset
|
50 # this can't be in a conditional otherwise automake 1.4 yells |
|
85c0aece7be9
[gaim-migrate @ 14184]
Gary Kramlich <grim@reaperworld.com>
parents:
11862
diff
changeset
|
51 dbus_example_la_LDFLAGS = -module -avoid-version $(GLIB_LIBS) $(DBUS_LIBS) |
|
85c0aece7be9
[gaim-migrate @ 14184]
Gary Kramlich <grim@reaperworld.com>
parents:
11862
diff
changeset
|
52 |
|
4202
59751fe608c5
[gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents:
4104
diff
changeset
|
53 if PLUGINS |
|
59751fe608c5
[gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents:
4104
diff
changeset
|
54 |
|
59751fe608c5
[gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents:
4104
diff
changeset
|
55 plugin_LTLIBRARIES = \ |
| 9215 | 56 extplacement.la \ |
|
10584
7de819b5ed68
[gaim-migrate @ 11988]
Etan Reisner <pidgin@unreliablesource.net>
parents:
9215
diff
changeset
|
57 gaimrc.la \ |
| 9215 | 58 history.la \ |
| 59 iconaway.la \ | |
| 60 idle.la \ | |
| 61 notify.la \ | |
| 62 relnot.la \ | |
| 63 spellchk.la \ | |
| 64 statenotify.la \ | |
|
11435
1a2eaba2bc13
[gaim-migrate @ 13672]
Gary Kramlich <grim@reaperworld.com>
parents:
11405
diff
changeset
|
65 timestamp.la \ |
|
1a2eaba2bc13
[gaim-migrate @ 13672]
Gary Kramlich <grim@reaperworld.com>
parents:
11405
diff
changeset
|
66 $(DBUS_LTLIB) |
|
5587
1c55b1540e18
[gaim-migrate @ 5991]
Christian Hammond <chipx86@chipx86.com>
parents:
5267
diff
changeset
|
67 |
| 11171 | 68 |
| 9215 | 69 extplacement_la_SOURCES = extplacement.c |
|
10584
7de819b5ed68
[gaim-migrate @ 11988]
Etan Reisner <pidgin@unreliablesource.net>
parents:
9215
diff
changeset
|
70 gaimrc_la_SOURCES = gaimrc.c |
| 9215 | 71 history_la_SOURCES = history.c |
| 72 iconaway_la_SOURCES = iconaway.c | |
| 73 idle_la_SOURCES = idle.c | |
| 74 notify_la_SOURCES = notify.c | |
| 75 relnot_la_SOURCES = relnot.c | |
| 76 spellchk_la_SOURCES = spellchk.c | |
| 77 statenotify_la_SOURCES = statenotify.c | |
| 78 timestamp_la_SOURCES = timestamp.c | |
|
4202
59751fe608c5
[gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents:
4104
diff
changeset
|
79 |
| 11171 | 80 if ENABLE_DBUS |
| 81 | |
| 82 CLEANFILES = dbus-example-bindings.c | |
| 83 dbus_example_la_SOURCES = dbus-example.c | |
| 84 | |
| 11337 | 85 .PHONY: always |
| 86 | |
| 87 $(top_builddir)/src/dbus-types.h: always | |
| 88 cd $(@D) && $(MAKE) $(AM_MAKEFLAGS) $(@F) | |
| 89 | |
| 11903 | 90 dbus-example-bindings.c: $(top_srcdir)/src/dbus-analyze-functions.py $(dbus_example_la_SOURCES) |
| 91 cat $(srcdir)/$(dbus_example_la_SOURCES) | \ | |
| 11337 | 92 $(PYTHON) $(top_srcdir)/src/dbus-analyze-functions.py --export-only > $@ |
| 11171 | 93 |
| 11337 | 94 $(dbus_example_la_OBJECTS) dbus-example.so: dbus-example-bindings.c $(top_builddir)/src/dbus-types.h |
| 11171 | 95 |
| 96 | |
| 97 endif # ENABLE_DBUS | |
| 98 | |
|
5205
fefad67de2c7
[gaim-migrate @ 5573]
Christian Hammond <chipx86@chipx86.com>
parents:
4687
diff
changeset
|
99 endif # PLUGINS |
|
4202
59751fe608c5
[gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents:
4104
diff
changeset
|
100 |
|
59751fe608c5
[gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents:
4104
diff
changeset
|
101 EXTRA_DIST = \ |
|
6993
4e78ef5587e4
[gaim-migrate @ 7549]
Christian Hammond <chipx86@chipx86.com>
parents:
6694
diff
changeset
|
102 ChangeLog HOWTO \ |
| 9099 | 103 ChangeLog.API \ |
|
11030
f1c384340261
[gaim-migrate @ 12909]
Etan Reisner <pidgin@unreliablesource.net>
parents:
10889
diff
changeset
|
104 Makefile.mingw \ |
| 11903 | 105 contact_priority.c \ |
| 6302 | 106 filectl.c \ |
|
11030
f1c384340261
[gaim-migrate @ 12909]
Etan Reisner <pidgin@unreliablesource.net>
parents:
10889
diff
changeset
|
107 fortuneprofile.pl \ |
|
f1c384340261
[gaim-migrate @ 12909]
Etan Reisner <pidgin@unreliablesource.net>
parents:
10889
diff
changeset
|
108 gaim.pl \ |
| 11903 | 109 gaiminc.c \ |
| 110 gtk-signals-test.c \ | |
| 111 ipc-test-client.c \ | |
| 112 ipc-test-server.c \ | |
| 6302 | 113 mailchk.c \ |
| 8713 | 114 pluginpref_example.c \ |
| 6302 | 115 raw.c \ |
|
6485
70d5122bc3ff
[gaim-migrate @ 6999]
Christian Hammond <chipx86@chipx86.com>
parents:
6386
diff
changeset
|
116 signals-test.c \ |
|
11032
31c1c48daba1
[gaim-migrate @ 12912]
Etan Reisner <pidgin@unreliablesource.net>
parents:
11030
diff
changeset
|
117 simple.c |
|
4202
59751fe608c5
[gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents:
4104
diff
changeset
|
118 |
|
59751fe608c5
[gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents:
4104
diff
changeset
|
119 AM_CPPFLAGS = \ |
|
6360
2e23ccbccdec
[gaim-migrate @ 6864]
Christian Hammond <chipx86@chipx86.com>
parents:
6353
diff
changeset
|
120 -DDATADIR=\"$(datadir)\" \ |
|
4202
59751fe608c5
[gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents:
4104
diff
changeset
|
121 -DVERSION=\"$(VERSION)\" \ |
| 11903 | 122 -I$(top_builddir)/src \ |
|
6360
2e23ccbccdec
[gaim-migrate @ 6864]
Christian Hammond <chipx86@chipx86.com>
parents:
6353
diff
changeset
|
123 -I$(top_srcdir)/src \ |
|
4202
59751fe608c5
[gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents:
4104
diff
changeset
|
124 $(DEBUG_CFLAGS) \ |
|
6360
2e23ccbccdec
[gaim-migrate @ 6864]
Christian Hammond <chipx86@chipx86.com>
parents:
6353
diff
changeset
|
125 $(GTK_CFLAGS) \ |
| 11171 | 126 $(PLUGIN_CFLAGS) \ |
| 127 $(DBUS_CFLAGS) | |
|
4202
59751fe608c5
[gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents:
4104
diff
changeset
|
128 |
|
59751fe608c5
[gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents:
4104
diff
changeset
|
129 # |
|
59751fe608c5
[gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents:
4104
diff
changeset
|
130 # This part allows people to build their own plugins in here. |
|
59751fe608c5
[gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents:
4104
diff
changeset
|
131 # Yes, it's a mess. |
|
59751fe608c5
[gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents:
4104
diff
changeset
|
132 # |
|
392
df5127560034
[gaim-migrate @ 402]
Eric Warmenhoven <eric@warmenhoven.org>
parents:
391
diff
changeset
|
133 SUFFIXES = .c .so |
| 172 | 134 .c.so: |
|
6386
417f35ff8b3e
[gaim-migrate @ 6891]
Christian Hammond <chipx86@chipx86.com>
parents:
6371
diff
changeset
|
135 $(LIBTOOL) --mode=compile $(CC) -DHAVE_CONFIG_H -I$(top_srcdir) $(AM_CPPFLAGS) $(CFLAGS) -c $< -o tmp$@.lo $(PLUGIN_CFLAGS) |
|
2893
abf9303fb328
[gaim-migrate @ 2906]
Eric Warmenhoven <eric@warmenhoven.org>
parents:
2867
diff
changeset
|
136 $(LIBTOOL) --mode=link $(CC) $(CFLAGS) -o libtmp$@.la -rpath $(plugindir) tmp$@.lo $(LIBS) $(LDFLAGS) -module -avoid-version $(PLUGIN_LIBS) |
|
2342
b1050f14b429
[gaim-migrate @ 2355]
Eric Warmenhoven <eric@warmenhoven.org>
parents:
2327
diff
changeset
|
137 @rm -f tmp$@.lo tmp$@.o libtmp$@.la |
|
2476
ec21ec04cdeb
[gaim-migrate @ 2489]
Eric Warmenhoven <eric@warmenhoven.org>
parents:
2473
diff
changeset
|
138 @cp .libs/libtmp$@.so* $@ |
|
2342
b1050f14b429
[gaim-migrate @ 2355]
Eric Warmenhoven <eric@warmenhoven.org>
parents:
2327
diff
changeset
|
139 @rm -f .libs/libtmp$@.* |
