annotate src/protocols/toc/Makefile.am @ 12229:18f0dadb29cf

[gaim-migrate @ 14531] SF Patch #1366481 from Michael Carlson "The function gtk_smiley_tree_insert() in gtkimhtml.c is using up (on my system) the most CPU of all the functions in gaim whenever the preferences box is opened (tested by opening the preferences box 50 times and measuring with oprofile). The function is called some 297 times each time the prefs box is opened, and each time we call strlen() on a (usually 3 or 4) character string to see if the string is empty or not. I've eliminated the unnecessary call to strlen by checking the first element, and I've changed the while {} loop to a do {} while loop, because since we return if the string is empty at the beginning of the function, the same check on the first iteration of the loop is unnecessary. I believe it's faster for every case, even if only by a little bit." I don't know how necessary this is, but it doesn't hurt and it doesn't negatively impact the readability of the code. I also fixed an existing piece of code for which the compiler issued a warning. committer: Tailor Script <tailor@pidgin.im>
author Richard Laager <rlaager@wiktel.com>
date Sat, 26 Nov 2005 17:09:29 +0000
parents 6b1ecf40f3ba
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
6198
fcc28f5dd0c8 [gaim-migrate @ 6684]
Herman Bloggs <hermanator12002@yahoo.com>
parents: 4202
diff changeset
1 EXTRA_DIST = \
fcc28f5dd0c8 [gaim-migrate @ 6684]
Herman Bloggs <hermanator12002@yahoo.com>
parents: 4202
diff changeset
2 PROTOCOL \
fcc28f5dd0c8 [gaim-migrate @ 6684]
Herman Bloggs <hermanator12002@yahoo.com>
parents: 4202
diff changeset
3 Makefile.mingw
2287
1a1d68e12a86 [gaim-migrate @ 2297]
Eric Warmenhoven <eric@warmenhoven.org>
parents: 2086
diff changeset
4
2086
424a40f12a6c [gaim-migrate @ 2096]
Eric Warmenhoven <eric@warmenhoven.org>
parents:
diff changeset
5 pkgdir = $(libdir)/gaim
424a40f12a6c [gaim-migrate @ 2096]
Eric Warmenhoven <eric@warmenhoven.org>
parents:
diff changeset
6
4202
59751fe608c5 [gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents: 3411
diff changeset
7 TOCSOURCES = toc.c
59751fe608c5 [gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents: 3411
diff changeset
8
59751fe608c5 [gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents: 3411
diff changeset
9 AM_CFLAGS = $(st)
59751fe608c5 [gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents: 3411
diff changeset
10
2894
44140dae2865 [gaim-migrate @ 2907]
Eric Warmenhoven <eric@warmenhoven.org>
parents: 2341
diff changeset
11 libtoc_la_LDFLAGS = -module -avoid-version
2086
424a40f12a6c [gaim-migrate @ 2096]
Eric Warmenhoven <eric@warmenhoven.org>
parents:
diff changeset
12
424a40f12a6c [gaim-migrate @ 2096]
Eric Warmenhoven <eric@warmenhoven.org>
parents:
diff changeset
13 if STATIC_TOC
424a40f12a6c [gaim-migrate @ 2096]
Eric Warmenhoven <eric@warmenhoven.org>
parents:
diff changeset
14
8082
6b1ecf40f3ba [gaim-migrate @ 8781]
Nathan Walp <nwalp@pidgin.im>
parents: 7178
diff changeset
15 st = -DGAIM_STATIC_PRPL
2086
424a40f12a6c [gaim-migrate @ 2096]
Eric Warmenhoven <eric@warmenhoven.org>
parents:
diff changeset
16 noinst_LIBRARIES = libtoc.a
4202
59751fe608c5 [gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents: 3411
diff changeset
17 libtoc_a_SOURCES = $(TOCSOURCES)
59751fe608c5 [gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents: 3411
diff changeset
18 libtoc_a_CFLAGS = $(AM_CFLAGS)
3411
5df423e0bca8 [gaim-migrate @ 3430]
Christian Hammond <chipx86@chipx86.com>
parents: 2894
diff changeset
19
2086
424a40f12a6c [gaim-migrate @ 2096]
Eric Warmenhoven <eric@warmenhoven.org>
parents:
diff changeset
20 else
424a40f12a6c [gaim-migrate @ 2096]
Eric Warmenhoven <eric@warmenhoven.org>
parents:
diff changeset
21
424a40f12a6c [gaim-migrate @ 2096]
Eric Warmenhoven <eric@warmenhoven.org>
parents:
diff changeset
22 st =
4202
59751fe608c5 [gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents: 3411
diff changeset
23 pkg_LTLIBRARIES = libtoc.la
59751fe608c5 [gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents: 3411
diff changeset
24 libtoc_la_SOURCES = $(TOCSOURCES)
2086
424a40f12a6c [gaim-migrate @ 2096]
Eric Warmenhoven <eric@warmenhoven.org>
parents:
diff changeset
25
424a40f12a6c [gaim-migrate @ 2096]
Eric Warmenhoven <eric@warmenhoven.org>
parents:
diff changeset
26 endif
4202
59751fe608c5 [gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents: 3411
diff changeset
27
59751fe608c5 [gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents: 3411
diff changeset
28 AM_CPPFLAGS = \
59751fe608c5 [gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents: 3411
diff changeset
29 -I$(top_srcdir)/src \
6371
8f94cce8faa5 [gaim-migrate @ 6876]
Christian Hammond <chipx86@chipx86.com>
parents: 6360
diff changeset
30 $(GLIB_CFLAGS) \
4202
59751fe608c5 [gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents: 3411
diff changeset
31 $(DEBUG_CFLAGS)