annotate src/gaim-socket.h @ 7667:30593bf56e71

[gaim-migrate @ 8311] (23:56:25) shx: LSchiere: there's something wrong in my patch (23:56:34) Luke: okay (23:56:38) Luke: what's that (23:57:45) shx: I forgot to add a '0' a the end of a string (23:57:56) shx: in the gaim_mime_decode_field funcition (23:59:35) Luke: where in that? (00:00:16) shx: at the end, just before this (00:00:18) shx: if (*unencoded_start) (00:00:19) shx: n = strcpy(n, unencoded_start); (00:00:27) shx: whould be this (00:00:28) shx: *n = '\0'; (00:01:05) Luke: so you are just setting it to NULL (00:01:53) Luke: i don't understand why you need that n set at all inside that if, since you just return new on the next line down (00:03:35) shx: I doing some test right now, but I remember I added that because I had of some errors (00:05:04) Luke: i think what you may be hitting is a functional work around for not properly initializing variables, something that shouldn't work but does. because you shouldn't need to set something just before you return unless you are returning IT (or unless you are using staticly declared memory, in which case you might concievably be using that variable again when you next enter the function (00:05:55) shx: no (00:06:18) shx: n is a pointer to the end of the string, and changes as the while goes on (00:06:37) Luke: ah (00:06:42) shx: n doesn't matter (00:07:01) Luke: so should the *n = '\0' be inside the if or outside it? (00:07:30) shx: before the if (00:07:44) shx: *n = '\0'; (00:07:45) shx: if (*unencoded_start) (00:07:45) shx: n = strcpy(n, unencoded_start); (00:08:07) shx: in the case there is no *unencoded_start committer: Tailor Script <tailor@pidgin.im>
author Luke Schierer <lschiere@pidgin.im>
date Sun, 30 Nov 2003 05:10:24 +0000
parents 3da42b64304e
children fa6395637e2c
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
3478
3da42b64304e [gaim-migrate @ 3532]
Sean Egan <seanegan@gmail.com>
parents:
diff changeset
1 /*
3da42b64304e [gaim-migrate @ 3532]
Sean Egan <seanegan@gmail.com>
parents:
diff changeset
2 * gaim-remote
3da42b64304e [gaim-migrate @ 3532]
Sean Egan <seanegan@gmail.com>
parents:
diff changeset
3 *
3da42b64304e [gaim-migrate @ 3532]
Sean Egan <seanegan@gmail.com>
parents:
diff changeset
4 * Copyright (C) 2002, Sean Egan <bj91704@binghamton.edu>
3da42b64304e [gaim-migrate @ 3532]
Sean Egan <seanegan@gmail.com>
parents:
diff changeset
5 *
3da42b64304e [gaim-migrate @ 3532]
Sean Egan <seanegan@gmail.com>
parents:
diff changeset
6 * This program is free software; you can redistribute it and/or modify
3da42b64304e [gaim-migrate @ 3532]
Sean Egan <seanegan@gmail.com>
parents:
diff changeset
7 * it under the terms of the GNU General Public License as published by
3da42b64304e [gaim-migrate @ 3532]
Sean Egan <seanegan@gmail.com>
parents:
diff changeset
8 * the Free Software Foundation; either version 2 of the License, or
3da42b64304e [gaim-migrate @ 3532]
Sean Egan <seanegan@gmail.com>
parents:
diff changeset
9 * (at your option) any later version.
3da42b64304e [gaim-migrate @ 3532]
Sean Egan <seanegan@gmail.com>
parents:
diff changeset
10 *
3da42b64304e [gaim-migrate @ 3532]
Sean Egan <seanegan@gmail.com>
parents:
diff changeset
11 * This program is distributed in the hope that it will be useful,
3da42b64304e [gaim-migrate @ 3532]
Sean Egan <seanegan@gmail.com>
parents:
diff changeset
12 * but WITHOUT ANY WARRANTY; without even the implied warranty of
3da42b64304e [gaim-migrate @ 3532]
Sean Egan <seanegan@gmail.com>
parents:
diff changeset
13 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3da42b64304e [gaim-migrate @ 3532]
Sean Egan <seanegan@gmail.com>
parents:
diff changeset
14 * GNU General Public License for more details.
3da42b64304e [gaim-migrate @ 3532]
Sean Egan <seanegan@gmail.com>
parents:
diff changeset
15 *
3da42b64304e [gaim-migrate @ 3532]
Sean Egan <seanegan@gmail.com>
parents:
diff changeset
16 * You should have received a copy of the GNU General Public License
3da42b64304e [gaim-migrate @ 3532]
Sean Egan <seanegan@gmail.com>
parents:
diff changeset
17 * along with this program; if not, write to the Free Software
3da42b64304e [gaim-migrate @ 3532]
Sean Egan <seanegan@gmail.com>
parents:
diff changeset
18 * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
3da42b64304e [gaim-migrate @ 3532]
Sean Egan <seanegan@gmail.com>
parents:
diff changeset
19 *
3da42b64304e [gaim-migrate @ 3532]
Sean Egan <seanegan@gmail.com>
parents:
diff changeset
20 */
3da42b64304e [gaim-migrate @ 3532]
Sean Egan <seanegan@gmail.com>
parents:
diff changeset
21
3da42b64304e [gaim-migrate @ 3532]
Sean Egan <seanegan@gmail.com>
parents:
diff changeset
22 #ifndef _GAIM_SOCKET_H_
3da42b64304e [gaim-migrate @ 3532]
Sean Egan <seanegan@gmail.com>
parents:
diff changeset
23 #define _GAIM_SOCKET_H_
3da42b64304e [gaim-migrate @ 3532]
Sean Egan <seanegan@gmail.com>
parents:
diff changeset
24
3da42b64304e [gaim-migrate @ 3532]
Sean Egan <seanegan@gmail.com>
parents:
diff changeset
25 struct gaim_cui_packet {
3da42b64304e [gaim-migrate @ 3532]
Sean Egan <seanegan@gmail.com>
parents:
diff changeset
26 guchar type;
3da42b64304e [gaim-migrate @ 3532]
Sean Egan <seanegan@gmail.com>
parents:
diff changeset
27 guchar subtype;
3da42b64304e [gaim-migrate @ 3532]
Sean Egan <seanegan@gmail.com>
parents:
diff changeset
28 guint32 length;
3da42b64304e [gaim-migrate @ 3532]
Sean Egan <seanegan@gmail.com>
parents:
diff changeset
29 char *data;
3da42b64304e [gaim-migrate @ 3532]
Sean Egan <seanegan@gmail.com>
parents:
diff changeset
30 };
3da42b64304e [gaim-migrate @ 3532]
Sean Egan <seanegan@gmail.com>
parents:
diff changeset
31
3da42b64304e [gaim-migrate @ 3532]
Sean Egan <seanegan@gmail.com>
parents:
diff changeset
32
3da42b64304e [gaim-migrate @ 3532]
Sean Egan <seanegan@gmail.com>
parents:
diff changeset
33 void cui_send_packet (int fd, struct gaim_cui_packet *p);
3da42b64304e [gaim-migrate @ 3532]
Sean Egan <seanegan@gmail.com>
parents:
diff changeset
34 gint gaim_connect_to_session(gint session);
3da42b64304e [gaim-migrate @ 3532]
Sean Egan <seanegan@gmail.com>
parents:
diff changeset
35 gboolean gaim_session_exists(int sess);
3da42b64304e [gaim-migrate @ 3532]
Sean Egan <seanegan@gmail.com>
parents:
diff changeset
36
3da42b64304e [gaim-migrate @ 3532]
Sean Egan <seanegan@gmail.com>
parents:
diff changeset
37 struct gaim_cui_packet *cui_packet_new(guchar type, guchar subtype);
3da42b64304e [gaim-migrate @ 3532]
Sean Egan <seanegan@gmail.com>
parents:
diff changeset
38 void cui_packet_free(struct gaim_cui_packet *p);
3da42b64304e [gaim-migrate @ 3532]
Sean Egan <seanegan@gmail.com>
parents:
diff changeset
39 void cui_packet_append_string(struct gaim_cui_packet *p, char *str);
3da42b64304e [gaim-migrate @ 3532]
Sean Egan <seanegan@gmail.com>
parents:
diff changeset
40 void cui_packet_append_char(struct gaim_cui_packet *p, char c);
3da42b64304e [gaim-migrate @ 3532]
Sean Egan <seanegan@gmail.com>
parents:
diff changeset
41 void cui_packet_append_raw(struct gaim_cui_packet *p, char *str, int len);
3da42b64304e [gaim-migrate @ 3532]
Sean Egan <seanegan@gmail.com>
parents:
diff changeset
42
3da42b64304e [gaim-migrate @ 3532]
Sean Egan <seanegan@gmail.com>
parents:
diff changeset
43
3da42b64304e [gaim-migrate @ 3532]
Sean Egan <seanegan@gmail.com>
parents:
diff changeset
44 #endif /* _GAIM_SOCKET_H_ */