Mercurial > pidgin
annotate src/protocols/irc/Makefile.mingw @ 7667:30593bf56e71
[gaim-migrate @ 8311]
(23:56:25) shx: LSchiere: there's something wrong in my patch
(23:56:34) Luke: okay
(23:56:38) Luke: what's that
(23:57:45) shx: I forgot to add a '0' a the end of a string
(23:57:56) shx: in the gaim_mime_decode_field funcition
(23:59:35) Luke: where in that?
(00:00:16) shx: at the end, just before this
(00:00:18) shx: if (*unencoded_start)
(00:00:19) shx: n = strcpy(n, unencoded_start);
(00:00:27) shx: whould be this
(00:00:28) shx: *n = '\0';
(00:01:05) Luke: so you are just setting it to NULL
(00:01:53) Luke: i don't understand why you need that n set at all inside
that if, since you just return new on the next line down
(00:03:35) shx: I doing some test right now, but I remember I added that
because I had of some errors
(00:05:04) Luke: i think what you may be hitting is a functional work
around for not properly initializing variables, something that shouldn't
work but does. because you shouldn't need to set something just before you
return unless you are returning IT (or unless you are using staticly
declared memory, in which case you might concievably be using that variable
again when you next enter the function
(00:05:55) shx: no
(00:06:18) shx: n is a pointer to the end of the string, and changes as the
while goes on
(00:06:37) Luke: ah
(00:06:42) shx: n doesn't matter
(00:07:01) Luke: so should the *n = '\0' be inside the if or outside it?
(00:07:30) shx: before the if
(00:07:44) shx: *n = '\0';
(00:07:45) shx: if (*unencoded_start)
(00:07:45) shx: n = strcpy(n, unencoded_start);
(00:08:07) shx: in the case there is no *unencoded_start
committer: Tailor Script <tailor@pidgin.im>
| author | Luke Schierer <lschiere@pidgin.im> |
|---|---|
| date | Sun, 30 Nov 2003 05:10:24 +0000 |
| parents | c7de2a502d7c |
| children | e7f0f16057f8 |
| rev | line source |
|---|---|
| 3630 | 1 # |
| 2 # Makefile.mingw | |
| 3 # | |
| 4 # Description: Makefile for win32 (mingw) version of libirc | |
| 5 # | |
| 6 | |
| 7 # | |
| 8 # PATHS | |
| 9 # | |
| 10 | |
| 11 INCLUDE_DIR := . | |
| 12 GTK_TOP := ../../../../win32-dev/gtk_2_0 | |
| 13 GAIM_TOP := ../../.. | |
| 14 IRC_ROOT := . | |
| 15 GAIM_INSTALL_DIR := $(GAIM_TOP)/win32-install-dir | |
| 16 | |
| 17 ## | |
| 18 ## VARIABLE DEFINITIONS | |
| 19 ## | |
| 20 | |
| 21 TARGET = libirc | |
| 22 | |
| 23 # Compiler Options | |
| 24 | |
|
3718
fd3880c03f0d
[gaim-migrate @ 3851]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
3630
diff
changeset
|
25 CFLAGS = |
| 3630 | 26 |
|
3718
fd3880c03f0d
[gaim-migrate @ 3851]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
3630
diff
changeset
|
27 DEFINES = |
| 3630 | 28 |
| 29 # Static or Plugin... | |
| 30 ifeq ($(TYPE),STATIC) | |
| 31 DEFINES += -DSTATIC | |
| 32 DLL_INSTALL_DIR = $(GAIM_INSTALL_DIR) | |
| 33 else | |
| 34 ifeq ($(TYPE),PLUGIN) | |
| 35 DLL_INSTALL_DIR = $(GAIM_INSTALL_DIR)/plugins | |
| 36 endif | |
| 37 endif | |
| 38 | |
| 39 | |
| 40 ## | |
| 41 ## INCLUDE MAKEFILES | |
| 42 ## | |
| 43 | |
|
3718
fd3880c03f0d
[gaim-migrate @ 3851]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
3630
diff
changeset
|
44 include $(GAIM_TOP)/src/win32/global.mak |
| 3630 | 45 |
| 46 ## | |
| 47 ## INCLUDE PATHS | |
| 48 ## | |
| 49 | |
| 50 INCLUDE_PATHS += -I$(IRC_ROOT) \ | |
| 51 -I$(GTK_TOP)/include \ | |
| 52 -I$(GTK_TOP)/include/gtk-2.0 \ | |
| 53 -I$(GTK_TOP)/include/glib-2.0 \ | |
| 54 -I$(GTK_TOP)/include/pango-1.0 \ | |
| 55 -I$(GTK_TOP)/include/atk-1.0 \ | |
| 56 -I$(GTK_TOP)/lib/glib-2.0/include \ | |
| 57 -I$(GTK_TOP)/lib/gtk-2.0/include \ | |
| 58 -I$(GAIM_TOP)/src \ | |
| 59 -I$(GAIM_TOP)/src/win32 \ | |
| 60 -I$(GAIM_TOP) | |
| 61 | |
| 62 | |
| 63 LIB_PATHS = -L$(GTK_TOP)/lib \ | |
| 64 -L$(GAIM_TOP)/src | |
| 65 | |
| 66 | |
| 67 ## | |
| 68 ## SOURCES, OBJECTS | |
| 69 ## | |
| 70 | |
|
6342
c7de2a502d7c
[gaim-migrate @ 6841]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
5932
diff
changeset
|
71 C_SRC = cmds.c \ |
|
c7de2a502d7c
[gaim-migrate @ 6841]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
5932
diff
changeset
|
72 irc.c \ |
|
c7de2a502d7c
[gaim-migrate @ 6841]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
5932
diff
changeset
|
73 msgs.c \ |
|
c7de2a502d7c
[gaim-migrate @ 6841]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
5932
diff
changeset
|
74 parse.c |
| 3630 | 75 |
| 76 | |
| 77 OBJECTS = $(C_SRC:%.c=%.o) | |
| 78 | |
| 79 | |
| 80 ## | |
| 81 ## LIBRARIES | |
| 82 ## | |
| 83 | |
|
5932
bb7723f0b4b9
[gaim-migrate @ 6372]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
3718
diff
changeset
|
84 LIBS = -lgtk-win32-2.0 \ |
|
bb7723f0b4b9
[gaim-migrate @ 6372]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
3718
diff
changeset
|
85 -lglib-2.0 \ |
|
bb7723f0b4b9
[gaim-migrate @ 6372]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
3718
diff
changeset
|
86 -lgdk-win32-2.0 \ |
|
bb7723f0b4b9
[gaim-migrate @ 6372]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
3718
diff
changeset
|
87 -lgmodule-2.0 \ |
|
bb7723f0b4b9
[gaim-migrate @ 6372]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
3718
diff
changeset
|
88 -lgobject-2.0 \ |
|
bb7723f0b4b9
[gaim-migrate @ 6372]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
3718
diff
changeset
|
89 -lws2_32 \ |
|
bb7723f0b4b9
[gaim-migrate @ 6372]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
3718
diff
changeset
|
90 -lintl \ |
|
bb7723f0b4b9
[gaim-migrate @ 6372]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
3718
diff
changeset
|
91 -lgaim |
| 3630 | 92 |
| 93 | |
| 94 ## | |
| 95 ## RULES | |
| 96 ## | |
| 97 | |
| 98 # How to make a C file | |
| 99 | |
| 100 %.o: %.c | |
| 101 $(CC) $(CFLAGS) $(DEFINES) $(INCLUDE_PATHS) -o $@ -c $< | |
| 102 | |
| 103 ## | |
| 104 ## TARGET DEFINITIONS | |
| 105 ## | |
| 106 | |
| 107 .PHONY: all clean | |
| 108 | |
| 109 all: $(TARGET).dll | |
| 110 | |
| 111 install: | |
| 112 cp $(IRC_ROOT)/$(TARGET).dll $(DLL_INSTALL_DIR) | |
| 113 | |
| 114 | |
| 115 ## | |
| 116 ## BUILD Dependencies | |
| 117 ## | |
| 118 | |
| 119 $(GAIM_TOP)/src/gaim.lib: | |
| 120 $(MAKE) -C $(GAIM_TOP)/src -f Makefile.mingw gaim.lib | |
| 121 | |
| 122 ## | |
| 123 ## BUILD DLL | |
| 124 ## | |
| 125 | |
|
5932
bb7723f0b4b9
[gaim-migrate @ 6372]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
3718
diff
changeset
|
126 $(TARGET).dll: $(OBJECTS) $(GAIM_TOP)/src/gaim.lib |
|
bb7723f0b4b9
[gaim-migrate @ 6372]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
3718
diff
changeset
|
127 $(CC) -shared $(OBJECTS) $(LIB_PATHS) $(LIBS) $(DLL_LD_FLAGS) -Wl,--out-implib,$(TARGET).lib -o $(TARGET).dll |
| 3630 | 128 |
| 129 ## | |
| 130 ## CLEAN RULES | |
| 131 ## | |
| 132 | |
| 133 clean: | |
| 134 rm -rf *.o | |
| 135 rm -rf $(TARGET).dll | |
| 136 rm -rf $(TARGET).lib |
