Mercurial > pidgin
annotate src/protocols/toc/Makefile.am @ 7667:30593bf56e71
[gaim-migrate @ 8311]
(23:56:25) shx: LSchiere: there's something wrong in my patch
(23:56:34) Luke: okay
(23:56:38) Luke: what's that
(23:57:45) shx: I forgot to add a '0' a the end of a string
(23:57:56) shx: in the gaim_mime_decode_field funcition
(23:59:35) Luke: where in that?
(00:00:16) shx: at the end, just before this
(00:00:18) shx: if (*unencoded_start)
(00:00:19) shx: n = strcpy(n, unencoded_start);
(00:00:27) shx: whould be this
(00:00:28) shx: *n = '\0';
(00:01:05) Luke: so you are just setting it to NULL
(00:01:53) Luke: i don't understand why you need that n set at all inside
that if, since you just return new on the next line down
(00:03:35) shx: I doing some test right now, but I remember I added that
because I had of some errors
(00:05:04) Luke: i think what you may be hitting is a functional work
around for not properly initializing variables, something that shouldn't
work but does. because you shouldn't need to set something just before you
return unless you are returning IT (or unless you are using staticly
declared memory, in which case you might concievably be using that variable
again when you next enter the function
(00:05:55) shx: no
(00:06:18) shx: n is a pointer to the end of the string, and changes as the
while goes on
(00:06:37) Luke: ah
(00:06:42) shx: n doesn't matter
(00:07:01) Luke: so should the *n = '\0' be inside the if or outside it?
(00:07:30) shx: before the if
(00:07:44) shx: *n = '\0';
(00:07:45) shx: if (*unencoded_start)
(00:07:45) shx: n = strcpy(n, unencoded_start);
(00:08:07) shx: in the case there is no *unencoded_start
committer: Tailor Script <tailor@pidgin.im>
| author | Luke Schierer <lschiere@pidgin.im> |
|---|---|
| date | Sun, 30 Nov 2003 05:10:24 +0000 |
| parents | eb3356588ef5 |
| children | 6b1ecf40f3ba |
| rev | line source |
|---|---|
|
6198
fcc28f5dd0c8
[gaim-migrate @ 6684]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
4202
diff
changeset
|
1 EXTRA_DIST = \ |
|
fcc28f5dd0c8
[gaim-migrate @ 6684]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
4202
diff
changeset
|
2 PROTOCOL \ |
|
fcc28f5dd0c8
[gaim-migrate @ 6684]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
4202
diff
changeset
|
3 Makefile.mingw |
|
2287
1a1d68e12a86
[gaim-migrate @ 2297]
Eric Warmenhoven <eric@warmenhoven.org>
parents:
2086
diff
changeset
|
4 |
| 2086 | 5 pkgdir = $(libdir)/gaim |
| 6 | |
|
4202
59751fe608c5
[gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents:
3411
diff
changeset
|
7 TOCSOURCES = toc.c |
|
59751fe608c5
[gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents:
3411
diff
changeset
|
8 |
|
59751fe608c5
[gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents:
3411
diff
changeset
|
9 AM_CFLAGS = $(st) |
|
59751fe608c5
[gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents:
3411
diff
changeset
|
10 |
|
2894
44140dae2865
[gaim-migrate @ 2907]
Eric Warmenhoven <eric@warmenhoven.org>
parents:
2341
diff
changeset
|
11 libtoc_la_LDFLAGS = -module -avoid-version |
| 2086 | 12 |
| 13 if STATIC_TOC | |
| 14 | |
| 15 st = -DSTATIC | |
| 16 noinst_LIBRARIES = libtoc.a | |
|
4202
59751fe608c5
[gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents:
3411
diff
changeset
|
17 libtoc_a_SOURCES = $(TOCSOURCES) |
|
59751fe608c5
[gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents:
3411
diff
changeset
|
18 libtoc_a_CFLAGS = $(AM_CFLAGS) |
|
3411
5df423e0bca8
[gaim-migrate @ 3430]
Christian Hammond <chipx86@chipx86.com>
parents:
2894
diff
changeset
|
19 |
| 2086 | 20 else |
| 21 | |
| 22 st = | |
|
4202
59751fe608c5
[gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents:
3411
diff
changeset
|
23 pkg_LTLIBRARIES = libtoc.la |
|
59751fe608c5
[gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents:
3411
diff
changeset
|
24 libtoc_la_SOURCES = $(TOCSOURCES) |
| 2086 | 25 |
| 26 endif | |
|
4202
59751fe608c5
[gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents:
3411
diff
changeset
|
27 |
|
59751fe608c5
[gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents:
3411
diff
changeset
|
28 AM_CPPFLAGS = \ |
|
59751fe608c5
[gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents:
3411
diff
changeset
|
29 -I$(top_srcdir)/src \ |
|
6371
8f94cce8faa5
[gaim-migrate @ 6876]
Christian Hammond <chipx86@chipx86.com>
parents:
6360
diff
changeset
|
30 $(GLIB_CFLAGS) \ |
|
4202
59751fe608c5
[gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents:
3411
diff
changeset
|
31 $(DEBUG_CFLAGS) |
