Mercurial > pidgin
annotate plugins/gevolution/Makefile.am @ 10039:cf02e7104706
[gaim-migrate @ 10998]
A patch from rian hunter (chrono86):
In src/protocols/oscar/oscar.c, in the function
gaim_plugin_oscar_convert_to_best_encoding. g_convert
is called multiple times. As its 5th argument g_convert
takes a gsize* (8 byte), yet the argument to
gaim_plugin_oscar_convert_to_best_encoding is a int* (4
byte).
On LP64 machines this can allow the int* to be
overwritten. This is especially bad on big endian
64-bit machines, causing the high 32-bits to be written
into the low 32-bits of the int.
This is a quick fix patch that lets g_convert deal with
a gsize* pointer instead, then casting the value at
gsize* to the value at the int*.
A real fix would be to fix the aim_sendimext_args
structure to have a gsize instead of an int (and all
functions that use the aim_sendimext_args struct), and
changing gaim_plugin_oscar_convert_to_best_encoding to
accept a gsize*. of course, this woudl promote glib2
dependence, so that's probably not the best thing to do.
committer: Tailor Script <tailor@pidgin.im>
| author | Mark Doliner <mark@kingant.net> |
|---|---|
| date | Sat, 18 Sep 2004 23:17:18 +0000 |
| parents | 52473ca8f2e5 |
| children | ff4be2d1401d |
| rev | line source |
|---|---|
| 8089 | 1 plugindir = $(libdir)/gaim |
| 2 | |
| 3 gevolution_la_LDFLAGS = \ | |
| 4 -module -avoid-version \ | |
| 5 $(EVOLUTION_ADDRESSBOOK_LIBS) | |
| 6 | |
| 7 if PLUGINS | |
| 8 | |
| 9 plugin_LTLIBRARIES = gevolution.la | |
| 10 | |
| 11 gevolution_la_SOURCES = \ | |
| 12 add_buddy_dialog.c \ | |
| 13 assoc-buddy.c \ | |
| 14 gevolution.c \ | |
| 8565 | 15 gevolution.h \ |
| 8089 | 16 gevo-util.c \ |
| 17 new_person_dialog.c | |
| 18 | |
| 19 endif | |
| 20 | |
| 21 gevolution_la_LIBADD = | |
| 22 | |
| 23 AM_CPPFLAGS = \ | |
| 24 -DDATADIR=\"$(datadir)\" \ | |
| 25 -DVERSION=\"$(VERSION)\" \ | |
| 26 -I$(top_srcdir)/src \ | |
| 27 $(EVOLUTION_ADDRESSBOOK_CFLAGS) \ | |
| 28 $(DEBUG_CFLAGS) \ | |
| 29 $(GTK_CFLAGS) |
