Mercurial > pidgin
annotate src/protocols/toc/Makefile.am @ 10039:cf02e7104706
[gaim-migrate @ 10998]
A patch from rian hunter (chrono86):
In src/protocols/oscar/oscar.c, in the function
gaim_plugin_oscar_convert_to_best_encoding. g_convert
is called multiple times. As its 5th argument g_convert
takes a gsize* (8 byte), yet the argument to
gaim_plugin_oscar_convert_to_best_encoding is a int* (4
byte).
On LP64 machines this can allow the int* to be
overwritten. This is especially bad on big endian
64-bit machines, causing the high 32-bits to be written
into the low 32-bits of the int.
This is a quick fix patch that lets g_convert deal with
a gsize* pointer instead, then casting the value at
gsize* to the value at the int*.
A real fix would be to fix the aim_sendimext_args
structure to have a gsize instead of an int (and all
functions that use the aim_sendimext_args struct), and
changing gaim_plugin_oscar_convert_to_best_encoding to
accept a gsize*. of course, this woudl promote glib2
dependence, so that's probably not the best thing to do.
committer: Tailor Script <tailor@pidgin.im>
| author | Mark Doliner <mark@kingant.net> |
|---|---|
| date | Sat, 18 Sep 2004 23:17:18 +0000 |
| parents | 6b1ecf40f3ba |
| children |
| rev | line source |
|---|---|
|
6198
fcc28f5dd0c8
[gaim-migrate @ 6684]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
4202
diff
changeset
|
1 EXTRA_DIST = \ |
|
fcc28f5dd0c8
[gaim-migrate @ 6684]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
4202
diff
changeset
|
2 PROTOCOL \ |
|
fcc28f5dd0c8
[gaim-migrate @ 6684]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
4202
diff
changeset
|
3 Makefile.mingw |
|
2287
1a1d68e12a86
[gaim-migrate @ 2297]
Eric Warmenhoven <eric@warmenhoven.org>
parents:
2086
diff
changeset
|
4 |
| 2086 | 5 pkgdir = $(libdir)/gaim |
| 6 | |
|
4202
59751fe608c5
[gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents:
3411
diff
changeset
|
7 TOCSOURCES = toc.c |
|
59751fe608c5
[gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents:
3411
diff
changeset
|
8 |
|
59751fe608c5
[gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents:
3411
diff
changeset
|
9 AM_CFLAGS = $(st) |
|
59751fe608c5
[gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents:
3411
diff
changeset
|
10 |
|
2894
44140dae2865
[gaim-migrate @ 2907]
Eric Warmenhoven <eric@warmenhoven.org>
parents:
2341
diff
changeset
|
11 libtoc_la_LDFLAGS = -module -avoid-version |
| 2086 | 12 |
| 13 if STATIC_TOC | |
| 14 | |
| 8082 | 15 st = -DGAIM_STATIC_PRPL |
| 2086 | 16 noinst_LIBRARIES = libtoc.a |
|
4202
59751fe608c5
[gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents:
3411
diff
changeset
|
17 libtoc_a_SOURCES = $(TOCSOURCES) |
|
59751fe608c5
[gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents:
3411
diff
changeset
|
18 libtoc_a_CFLAGS = $(AM_CFLAGS) |
|
3411
5df423e0bca8
[gaim-migrate @ 3430]
Christian Hammond <chipx86@chipx86.com>
parents:
2894
diff
changeset
|
19 |
| 2086 | 20 else |
| 21 | |
| 22 st = | |
|
4202
59751fe608c5
[gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents:
3411
diff
changeset
|
23 pkg_LTLIBRARIES = libtoc.la |
|
59751fe608c5
[gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents:
3411
diff
changeset
|
24 libtoc_la_SOURCES = $(TOCSOURCES) |
| 2086 | 25 |
| 26 endif | |
|
4202
59751fe608c5
[gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents:
3411
diff
changeset
|
27 |
|
59751fe608c5
[gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents:
3411
diff
changeset
|
28 AM_CPPFLAGS = \ |
|
59751fe608c5
[gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents:
3411
diff
changeset
|
29 -I$(top_srcdir)/src \ |
|
6371
8f94cce8faa5
[gaim-migrate @ 6876]
Christian Hammond <chipx86@chipx86.com>
parents:
6360
diff
changeset
|
30 $(GLIB_CFLAGS) \ |
|
4202
59751fe608c5
[gaim-migrate @ 4438]
Christian Hammond <chipx86@chipx86.com>
parents:
3411
diff
changeset
|
31 $(DEBUG_CFLAGS) |
