Mercurial > pidgin
annotate console/plugins/Makefile.am @ 15784:eed84b59c252
There were a few problems here
1. Raw gnutls error codes were being printed in debug messages. This
isn't necessarily bad, but it's much less useful than the text
returned from gnutls_strerror(). Never underestimate the value of
good error handling.
2. ssl_gnutls_read() and ssl_gnutls_write() were returning 0 when there
was an error reading from or writing to the ssl connection. They
should return -1 to indicate failure (0 normally indicates that the
server closed the connection)
3. ssl_gnutls_read() and ssl_gnutls_write() weren't setting errno when
they failed. errno would be set to something random, which seemed
to frequently be EAGAIN for me when reading, which causes Gaim to
keep trying to read from the connection even though it's closed.
Ideally ssl-gnutls.c would have a function equivalent to set_errno()
in ssl-nss.c, but the gnutls documentation does a poor job of
telling you what possible error codes could be returned from
gnutls_record_recv() and gnutls_record_send()
Even better would be if we allowed the ssl plugins to keep track of
the error message themselves, then added a new ssl ops function
to fetch the message from the plugin.
| author | Mark Doliner <mark@kingant.net> |
|---|---|
| date | Tue, 13 Mar 2007 06:53:43 +0000 |
| parents | 5fe8042783c1 |
| children |
| rev | line source |
|---|---|
| 14674 | 1 gntgf_la_LDFLAGS = -module -avoid-version |
| 2 gnthistory_la_LDFLAGS = -module -avoid-version | |
|
14715
04f03667702f
[gaim-migrate @ 17469]
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
14674
diff
changeset
|
3 gntlastlog_la_LDFLAGS = -module -avoid-version |
|
14139
44ec6c7cbc76
[gaim-migrate @ 16781]
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff
changeset
|
4 |
|
44ec6c7cbc76
[gaim-migrate @ 16781]
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff
changeset
|
5 if PLUGINS |
|
44ec6c7cbc76
[gaim-migrate @ 16781]
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff
changeset
|
6 |
|
44ec6c7cbc76
[gaim-migrate @ 16781]
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff
changeset
|
7 plugin_LTLIBRARIES = \ |
|
14223
7c560c01b8f9
[gaim-migrate @ 16904]
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
14139
diff
changeset
|
8 gntgf.la \ |
|
14715
04f03667702f
[gaim-migrate @ 17469]
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
14674
diff
changeset
|
9 gnthistory.la \ |
|
04f03667702f
[gaim-migrate @ 17469]
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
14674
diff
changeset
|
10 gntlastlog.la |
|
14139
44ec6c7cbc76
[gaim-migrate @ 16781]
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff
changeset
|
11 |
|
44ec6c7cbc76
[gaim-migrate @ 16781]
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff
changeset
|
12 plugindir = $(libdir)/gaim |
|
44ec6c7cbc76
[gaim-migrate @ 16781]
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff
changeset
|
13 |
| 14673 | 14 gntgf_la_SOURCES = gntgf.c |
| 15 gnthistory_la_SOURCES = gnthistory.c | |
|
15322
daf402269760
[gaim-migrate @ 18113]
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
14764
diff
changeset
|
16 gntlastlog_la_SOURCES = lastlog.c |
|
daf402269760
[gaim-migrate @ 18113]
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
14764
diff
changeset
|
17 |
|
daf402269760
[gaim-migrate @ 18113]
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
14764
diff
changeset
|
18 gntgf_la_CFLAGS = $(X11_CFLAGS) |
|
14139
44ec6c7cbc76
[gaim-migrate @ 16781]
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff
changeset
|
19 |
| 14674 | 20 gntgf_la_LIBADD = $(GLIB_LIBS) $(X11_LIBS) $(top_builddir)/console/libgnt/libgnt.la |
| 21 gnthistory_la_LIBADD = $(GLIB_LIBS) | |
|
14715
04f03667702f
[gaim-migrate @ 17469]
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
14674
diff
changeset
|
22 gntlastlog_la_LIBADD = $(GLIB_LIBS) |
| 14674 | 23 |
|
14139
44ec6c7cbc76
[gaim-migrate @ 16781]
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff
changeset
|
24 endif # PLUGINS |
|
44ec6c7cbc76
[gaim-migrate @ 16781]
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff
changeset
|
25 |
|
44ec6c7cbc76
[gaim-migrate @ 16781]
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff
changeset
|
26 EXTRA_DIST = |
|
44ec6c7cbc76
[gaim-migrate @ 16781]
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff
changeset
|
27 |
|
44ec6c7cbc76
[gaim-migrate @ 16781]
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff
changeset
|
28 AM_CPPFLAGS = \ |
|
44ec6c7cbc76
[gaim-migrate @ 16781]
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff
changeset
|
29 -DDATADIR=\"$(datadir)\" \ |
|
44ec6c7cbc76
[gaim-migrate @ 16781]
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff
changeset
|
30 -DVERSION=\"$(VERSION)\" \ |
|
15373
5fe8042783c1
Rename gtk/ and libgaim/ to pidgin/ and libpurple/
Sean Egan <seanegan@gmail.com>
parents:
15322
diff
changeset
|
31 -I$(top_builddir)/libpurple \ |
|
5fe8042783c1
Rename gtk/ and libgaim/ to pidgin/ and libpurple/
Sean Egan <seanegan@gmail.com>
parents:
15322
diff
changeset
|
32 -I$(top_srcdir)/libpurple \ |
|
14764
f0292b71104b
[gaim-migrate @ 17521]
Etan Reisner <pidgin@unreliablesource.net>
parents:
14715
diff
changeset
|
33 -I$(top_srcdir) \ |
|
14223
7c560c01b8f9
[gaim-migrate @ 16904]
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
14139
diff
changeset
|
34 -I$(top_srcdir)/console \ |
|
7c560c01b8f9
[gaim-migrate @ 16904]
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
14139
diff
changeset
|
35 -I$(top_srcdir)/console/libgnt \ |
|
14139
44ec6c7cbc76
[gaim-migrate @ 16781]
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff
changeset
|
36 $(DEBUG_CFLAGS) \ |
|
44ec6c7cbc76
[gaim-migrate @ 16781]
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff
changeset
|
37 $(GLIB_CFLAGS) \ |
|
14437
13422c8f74a2
[gaim-migrate @ 17151]
Gary Kramlich <grim@reaperworld.com>
parents:
14396
diff
changeset
|
38 $(GNT_CFLAGS) \ |
|
14139
44ec6c7cbc76
[gaim-migrate @ 16781]
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff
changeset
|
39 $(PLUGIN_CFLAGS) |
|
44ec6c7cbc76
[gaim-migrate @ 16781]
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff
changeset
|
40 |
|
44ec6c7cbc76
[gaim-migrate @ 16781]
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff
changeset
|
41 # |
|
44ec6c7cbc76
[gaim-migrate @ 16781]
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff
changeset
|
42 # This part allows people to build their own plugins in here. |
|
44ec6c7cbc76
[gaim-migrate @ 16781]
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff
changeset
|
43 # Yes, it's a mess. |
|
44ec6c7cbc76
[gaim-migrate @ 16781]
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff
changeset
|
44 # |
|
44ec6c7cbc76
[gaim-migrate @ 16781]
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff
changeset
|
45 SUFFIXES = .c .so |
|
44ec6c7cbc76
[gaim-migrate @ 16781]
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff
changeset
|
46 .c.so: |
|
44ec6c7cbc76
[gaim-migrate @ 16781]
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff
changeset
|
47 $(LIBTOOL) --mode=compile $(CC) -DHAVE_CONFIG_H -I$(top_srcdir) $(AM_CPPFLAGS) $(CFLAGS) -c $< -o tmp$@.lo $(PLUGIN_CFLAGS) |
|
44ec6c7cbc76
[gaim-migrate @ 16781]
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff
changeset
|
48 $(LIBTOOL) --mode=link $(CC) $(CFLAGS) -o libtmp$@.la -rpath $(plugindir) tmp$@.lo $(LIBS) $(LDFLAGS) -module -avoid-version $(PLUGIN_LIBS) |
|
44ec6c7cbc76
[gaim-migrate @ 16781]
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff
changeset
|
49 @rm -f tmp$@.lo tmp$@.o libtmp$@.la |
|
44ec6c7cbc76
[gaim-migrate @ 16781]
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff
changeset
|
50 @cp .libs/libtmp$@.so* $@ |
|
44ec6c7cbc76
[gaim-migrate @ 16781]
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff
changeset
|
51 @rm -f .libs/libtmp$@.* |
