Mercurial > pidgin
annotate PROGRAMMING_NOTES @ 14278:f71894e1700d
[gaim-migrate @ 16963]
Fix a crazy bug that we found at meebo. I'm not sure it
affects gtk Gaim in quite the same way, but what was
happeing is that the conversation sequence number should
be incremented by 1 each time a new conversation is
created (whether created by someone else or created by
you). However, in one place in Gaim conv_seq was being
incremented BEFORE it was used and in another it was
being incremented AFTER it was used. This can lead to
a sequence number being used twice.
committer: Tailor Script <tailor@pidgin.im>
| author | Mark Doliner <mark@kingant.net> |
|---|---|
| date | Mon, 21 Aug 2006 22:50:58 +0000 |
| parents | da88e2cd5c53 |
| children | 83ec0b408926 |
| rev | line source |
|---|---|
| 3630 | 1 Notes on keeping GAIM OS independant |
| 2 ------------------------------------ | |
| 3 | |
| 4 General | |
| 5 ------- | |
| 6 - Use G_DIR_SEPARATOR_S and G_DIR_SEPARATOR for paths | |
| 7 | |
| 8 - Use g_getenv, g_snprintf, g_vsnprintf | |
| 9 | |
| 10 - Use gaim_home_dir instead of g_get_home_dir or g_getenv("HOME") | |
| 11 | |
|
3713
e3a8baffcc24
[gaim-migrate @ 3846]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
3630
diff
changeset
|
12 - Make sure when including win32dep.h that it is the last header to |
|
e3a8baffcc24
[gaim-migrate @ 3846]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
3630
diff
changeset
|
13 be included. |
| 3630 | 14 |
|
4482
59ff9d0b7b85
[gaim-migrate @ 4757]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
4062
diff
changeset
|
15 - Open binary files when reading or writing with 'b' mode. |
|
59ff9d0b7b85
[gaim-migrate @ 4757]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
4062
diff
changeset
|
16 |
|
59ff9d0b7b85
[gaim-migrate @ 4757]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
4062
diff
changeset
|
17 e.g: fopen("somefile", "wb"); |
|
59ff9d0b7b85
[gaim-migrate @ 4757]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
4062
diff
changeset
|
18 |
|
59ff9d0b7b85
[gaim-migrate @ 4757]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
4062
diff
changeset
|
19 Not doing so will open files in windows using defaut translation mode. |
|
59ff9d0b7b85
[gaim-migrate @ 4757]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
4062
diff
changeset
|
20 i.e. newline -> <CR><LF> |
|
59ff9d0b7b85
[gaim-migrate @ 4757]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
4062
diff
changeset
|
21 |
|
4062
e074172f4a41
[gaim-migrate @ 4272]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
3713
diff
changeset
|
22 Paths |
|
e074172f4a41
[gaim-migrate @ 4272]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
3713
diff
changeset
|
23 ----- |
|
e074172f4a41
[gaim-migrate @ 4272]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
3713
diff
changeset
|
24 |
|
e074172f4a41
[gaim-migrate @ 4272]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
3713
diff
changeset
|
25 - DATADIR, LOCALEDIR & LIBDIR are defined in wingaim as functions. |
|
e074172f4a41
[gaim-migrate @ 4272]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
3713
diff
changeset
|
26 Doing the following will therefore break the windows build: |
|
e074172f4a41
[gaim-migrate @ 4272]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
3713
diff
changeset
|
27 |
|
e074172f4a41
[gaim-migrate @ 4272]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
3713
diff
changeset
|
28 printf("File in DATADIR is: %s\n", DATADIR G_DIR_SEPARATOR_S "pic.png"); |
|
e074172f4a41
[gaim-migrate @ 4272]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
3713
diff
changeset
|
29 |
|
e074172f4a41
[gaim-migrate @ 4272]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
3713
diff
changeset
|
30 it should be: |
|
e074172f4a41
[gaim-migrate @ 4272]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
3713
diff
changeset
|
31 |
|
e074172f4a41
[gaim-migrate @ 4272]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
3713
diff
changeset
|
32 printf("File in DATADIR is: %s%s%s\n", DATADIR, G_DIR_SEPARATOR_S, "pic.png"); |
|
e074172f4a41
[gaim-migrate @ 4272]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
3713
diff
changeset
|
33 |
| 3630 | 34 PLUGINS & PROTOS |
| 35 ---------------- | |
| 36 | |
| 37 - G_MODULE_EXPORT all functions which are to be accessed from outside the | |
| 38 scope of its "dll" or "so". (E.G. gaim_plugin_init) | |
| 39 | |
| 40 - G_MODULE_IMPORT all global variables which are located outside your | |
| 41 dynamic library. (E.G. connections) | |
| 42 | |
| 43 (Not doing this will cause "Memory Access Violations" in Win32) |
