Mercurial > pidgin
view plugins/crazychat/camdata.h @ 12229:18f0dadb29cf
[gaim-migrate @ 14531]
SF Patch #1366481 from Michael Carlson
"The function gtk_smiley_tree_insert() in gtkimhtml.c is
using up (on my system) the most CPU of all the
functions in gaim whenever the preferences box is
opened (tested by opening the preferences box 50 times
and measuring with oprofile).
The function is called some 297 times each time the
prefs box is opened, and each time we call strlen() on
a (usually 3 or 4) character string to see if the
string is empty or not.
I've eliminated the unnecessary call to strlen by
checking the first element, and I've changed the while
{} loop to a do {} while loop, because since we return
if the string is empty at the beginning of the
function, the same check on the first iteration of the
loop is unnecessary.
I believe it's faster for every case, even if only by a
little bit."
I don't know how necessary this is, but it doesn't hurt and it doesn't negatively impact the readability of the code.
I also fixed an existing piece of code for which the compiler issued a warning.
committer: Tailor Script <tailor@pidgin.im>
| author | Richard Laager <rlaager@wiktel.com> |
|---|---|
| date | Sat, 26 Nov 2005 17:09:29 +0000 |
| parents | ed017b9c532d |
| children | fc464a0abccc |
line wrap: on
line source
/* * camdata.h * basecame * * Created by CS194 on Mon Apr 26 2004. * Copyright (c) 2004 __MyCompanyName__. All rights reserved. * */ #pragma once #ifdef __APPLE_CC__ // #include <Carbon/Carbon.h> #include <QuickTime/QuickTime.h> #else // #include <Carbon.h> #include <QuickTime.h> #endif typedef struct { GWorldPtr gw; GWorldPtr overlay; GWorldPtr histoWorld; Rect bounds; WindowPtr window; ImageSequence drawSeq; UInt32 redMin, redMax; UInt32 greenMin, greenMax; UInt32 blueMin, blueMax; long selectedIndex; OSType effect; TimeBase effectTimeBase; QTAtomContainer effectParams; ImageDescriptionHandle effectDesc, effectDesc2; } mungDataRecord; typedef mungDataRecord *mungDataPtr; OSErr DisposeMungData(void); OSErr InitializeMungData(Rect bounds); void SetCurrentClamp(short index); //void BlitOneMungData(mungDataRecord *theMungData); //void AdjustColorClampEndpoints(short hMouseCoord); //void IncrementCurrentClamp(); //void DecrementCurrentClamp(); void SetMungDataColorDefaults(); CGrafPtr GetMungDataWindowPort(); GWorldPtr GetMungDataOffscreen(void); //OSType GetMungDataEffectType(); //long GetCurrentClamp(); //void SetCurrentClamp(short index); void GetMungDataBoundsRect(Rect *movieRect); //CGrafPtr GetMungDataWindowPort(); void SetMungDataDrawSeq(ImageSequence theDrawSeq); //ImageSequence GetMungDataDrawSeq();
