Mercurial > pidgin
view plugins/crazychat/cc_interface.h @ 12229:18f0dadb29cf
[gaim-migrate @ 14531]
SF Patch #1366481 from Michael Carlson
"The function gtk_smiley_tree_insert() in gtkimhtml.c is
using up (on my system) the most CPU of all the
functions in gaim whenever the preferences box is
opened (tested by opening the preferences box 50 times
and measuring with oprofile).
The function is called some 297 times each time the
prefs box is opened, and each time we call strlen() on
a (usually 3 or 4) character string to see if the
string is empty or not.
I've eliminated the unnecessary call to strlen by
checking the first element, and I've changed the while
{} loop to a do {} while loop, because since we return
if the string is empty at the beginning of the
function, the same check on the first iteration of the
loop is unnecessary.
I believe it's faster for every case, even if only by a
little bit."
I don't know how necessary this is, but it doesn't hurt and it doesn't negatively impact the readability of the code.
I also fixed an existing piece of code for which the compiler issued a warning.
committer: Tailor Script <tailor@pidgin.im>
| author | Richard Laager <rlaager@wiktel.com> |
|---|---|
| date | Sat, 26 Nov 2005 17:09:29 +0000 |
| parents | 8bcd4d4ccef6 |
| children |
line wrap: on
line source
#ifndef __CC_INTERFACE_H__ #define __CC_INTERFACE_H__ #include <gtk/gtk.h> #include "crazychat.h" /* XXX feature encapsulation: still in flux, not stable XXX */ //charlie typedef enum {REMOTE, LOCAL} OUTPUT; gboolean configure(GtkWidget *widget, GdkEventConfigure *event, void *data); #ifdef DISABLE_MODELS #define draw(a, b, c) 1 #define setupDrawlists(a) #else gboolean draw(GtkWidget *widget, GdkEventExpose *event, void *data); void setupDrawlists(OUTPUT output); #endif void init (GtkWidget *widget, void *data); void setupLighting(GtkWidget *widget); struct cc_features { guint8 head_size; guint8 left_eye_open, right_eye_open; /*booleans*/ guint8 mouth_open; /*percentage*/ guint8 head_x_rot, head_y_rot, head_z_rot; /* head rotation */ guint8 x, y; /*center of head*/ guint8 head_color, appendage_color, lid_color, right_iris_color, left_iris_color; //colors guint8 mode, kind; }; struct output_instance { struct cc_features *features; struct cc_session *session; float past_y; OUTPUT my_output; GtkWidget *widget; GtkWidget *box; }; struct input_instance { int timer_id; struct cc_features face; GtkWidget *widget; GtkWidget *box; GtkWidget *button; GtkWidget *label; GtkWidget *model; GtkWidget *head, *appendage, *lid, *right_iris, *left_iris; struct output_instance output; }; struct output_handlers { int (*configure)(GtkWidget *widget, GdkEventConfigure *event, void *data); void (*init) (GtkWidget *widget, void *data); gboolean (*draw) (GtkWidget *widget, GdkEventExpose *event, void *data); }; struct cc_session { struct crazychat *cc; /**< crazychat global data */ char *name; /**< session peer */ guint32 peer_ip; /**< peer's ip addr, nbo */ guint16 peer_port; /**< peer's port hbo */ struct sockaddr_in peer; /**< peer udp sock addr */ CC_STATE state; /**< connection state */ int timer_id; /**< glib timer callback id */ int tcp_sock; /**< tcp socket connection */ int udp_sock; /**< udp socket connection */ struct cc_features features; /**< network peer features */ struct output_instance *output; /**< output instance data */ filter_bank *filter; /**< filter instance */ }; struct crazychat { guint16 tcp_port; /**< tcp port to bind on */ guint16 udp_port; /**< udp session data port */ struct cc_session_node *sessions; /**< list of sessions */ struct input_instance *input_data; /**< input instance data */ gboolean features_state; /**< features state on/off */ }; /* --- input feature interface --- */ #ifdef _DISABLE_QT_ #define init_input(a) NULL #define destroy_input(a) #else /** * Initializes the input subsystem. * @param cc global crazychat data structure * @return pointer to an input instance */ struct input_instance *init_input(struct crazychat *cc); /** * Destroys the input subsystem. * @param instance input instance */ void destroy_input(struct input_instance *instance); #endif /* _DISABLE_QT_ */ /* --- output feature interface --- */ /** * Initializes an output instance. * @param features pointer to features * @param session pointer to the crazychat session * @return pointer to the output instance */ struct output_instance *init_output(struct cc_features *features, struct cc_session *session); /** * Destroys an output instance. * @param instance output instance */ void destroy_output(struct output_instance *instance); #endif
