Mercurial > pidgin
view plugins/ipc-test-server.c @ 12229:18f0dadb29cf
[gaim-migrate @ 14531]
SF Patch #1366481 from Michael Carlson
"The function gtk_smiley_tree_insert() in gtkimhtml.c is
using up (on my system) the most CPU of all the
functions in gaim whenever the preferences box is
opened (tested by opening the preferences box 50 times
and measuring with oprofile).
The function is called some 297 times each time the
prefs box is opened, and each time we call strlen() on
a (usually 3 or 4) character string to see if the
string is empty or not.
I've eliminated the unnecessary call to strlen by
checking the first element, and I've changed the while
{} loop to a do {} while loop, because since we return
if the string is empty at the beginning of the
function, the same check on the first iteration of the
loop is unnecessary.
I believe it's faster for every case, even if only by a
little bit."
I don't know how necessary this is, but it doesn't hurt and it doesn't negatively impact the readability of the code.
I also fixed an existing piece of code for which the compiler issued a warning.
committer: Tailor Script <tailor@pidgin.im>
| author | Richard Laager <rlaager@wiktel.com> |
|---|---|
| date | Sat, 26 Nov 2005 17:09:29 +0000 |
| parents | bb0d7b719af2 |
| children |
line wrap: on
line source
/* * IPC test server plugin. * * Copyright (C) 2003 Christian Hammond. * * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU General Public License as * published by the Free Software Foundation; either version 2 of the * License, or (at your option) any later version. * * This program is distributed in the hope that it will be useful, but * WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA * 02111-1307, USA. */ #define IPC_TEST_SERVER_PLUGIN_ID "core-ipc-test-server" #include "internal.h" #include "debug.h" #include "plugin.h" #include "version.h" static int add_func(int i1, int i2) { gaim_debug_misc("ipc-test-server", "Got %d, %d, returning %d\n", i1, i2, i1 + i2); return i1 + i2; } static int sub_func(int i1, int i2) { gaim_debug_misc("ipc-test-server", "Got %d, %d, returning %d\n", i1, i2, i1 - i2); return i1 - i2; } static gboolean plugin_load(GaimPlugin *plugin) { gaim_plugin_ipc_register(plugin, "add", GAIM_CALLBACK(add_func), gaim_marshal_INT__INT_INT, gaim_value_new(GAIM_TYPE_INT), 2, gaim_value_new(GAIM_TYPE_INT), gaim_value_new(GAIM_TYPE_INT)); gaim_plugin_ipc_register(plugin, "sub", GAIM_CALLBACK(sub_func), gaim_marshal_INT__INT_INT, gaim_value_new(GAIM_TYPE_INT), 2, gaim_value_new(GAIM_TYPE_INT), gaim_value_new(GAIM_TYPE_INT)); return TRUE; } static GaimPluginInfo info = { GAIM_PLUGIN_MAGIC, GAIM_MAJOR_VERSION, GAIM_MINOR_VERSION, GAIM_PLUGIN_STANDARD, /**< type */ NULL, /**< ui_requirement */ 0, /**< flags */ NULL, /**< dependencies */ GAIM_PRIORITY_DEFAULT, /**< priority */ IPC_TEST_SERVER_PLUGIN_ID, /**< id */ N_("IPC Test Server"), /**< name */ VERSION, /**< version */ /** summary */ N_("Test plugin IPC support, as a server."), /** description */ N_("Test plugin IPC support, as a server. This registers the IPC " "commands."), "Christian Hammond <chipx86@gnupdate.org>", /**< author */ GAIM_WEBSITE, /**< homepage */ plugin_load, /**< load */ NULL, /**< unload */ NULL, /**< destroy */ NULL, /**< ui_info */ NULL, /**< extra_info */ NULL, NULL }; static void init_plugin(GaimPlugin *plugin) { } GAIM_INIT_PLUGIN(ipctestserver, init_plugin, info)
