Mercurial > pidgin
view src/protocols/simple/sipmsg.c @ 12229:18f0dadb29cf
[gaim-migrate @ 14531]
SF Patch #1366481 from Michael Carlson
"The function gtk_smiley_tree_insert() in gtkimhtml.c is
using up (on my system) the most CPU of all the
functions in gaim whenever the preferences box is
opened (tested by opening the preferences box 50 times
and measuring with oprofile).
The function is called some 297 times each time the
prefs box is opened, and each time we call strlen() on
a (usually 3 or 4) character string to see if the
string is empty or not.
I've eliminated the unnecessary call to strlen by
checking the first element, and I've changed the while
{} loop to a do {} while loop, because since we return
if the string is empty at the beginning of the
function, the same check on the first iteration of the
loop is unnecessary.
I believe it's faster for every case, even if only by a
little bit."
I don't know how necessary this is, but it doesn't hurt and it doesn't negatively impact the readability of the code.
I also fixed an existing piece of code for which the compiler issued a warning.
committer: Tailor Script <tailor@pidgin.im>
| author | Richard Laager <rlaager@wiktel.com> |
|---|---|
| date | Sat, 26 Nov 2005 17:09:29 +0000 |
| parents | 2cf6d4cf2cb0 |
| children | 33ed71b35a43 |
line wrap: on
line source
/** * @file sipmsg.c * * gaim * * Copyright (C) 2005 Thomas Butter <butter@uni-mannheim.de> * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ #include "internal.h" #include "accountopt.h" #include "blist.h" #include "conversation.h" #include "debug.h" #include "notify.h" #include "prpl.h" #include "plugin.h" #include "util.h" #include "version.h" #include "simple.h" #include "sipmsg.h" struct sipmsg *sipmsg_parse_msg(gchar *msg) { char *tmp = strstr(msg, "\r\n\r\n"); struct sipmsg *smsg; if(!tmp) return NULL; tmp[0]=0; smsg = sipmsg_parse_header(msg); tmp[0]='\r'; smsg->body = g_strdup(tmp+4); return smsg; } struct sipmsg *sipmsg_parse_header(gchar *header) { struct sipmsg *msg = g_new0(struct sipmsg,1); gchar **lines = g_strsplit(header,"\r\n",0); gchar **parts; gchar *dummy; gchar *dummy2; gchar *tmp; int i=1; if(!lines[0]) return NULL; parts = g_strsplit(lines[0], " ", 3); if(!parts[0] || !parts[1] || !parts[2]) { g_strfreev(parts); g_strfreev(lines); g_free(msg); return NULL; } if(strstr(parts[0],"SIP")) { /* numeric response */ msg->method = g_strdup(parts[2]); msg->response = strtol(parts[1],NULL,10); } else { /* request */ msg->method = g_strdup(parts[0]); msg->target = g_strdup(parts[1]); msg->response = 0; } g_strfreev(parts); for(i=1; lines[i] && strlen(lines[i])>2; i++) { parts = g_strsplit(lines[i], ":", 2); if(!parts[0] || !parts[1]) { g_strfreev(parts); g_strfreev(lines); g_free(msg); return NULL; } dummy = parts[1]; dummy2 = 0; while(*dummy==' ' || *dummy=='\t') dummy++; dummy2 = g_strdup(dummy); while(lines[i+1] && (lines[i+1][0]==' ' || lines[i+1][0]=='\t')) { i++; dummy = lines[i]; while(*dummy==' ' || *dummy=='\t') dummy++; tmp = g_strdup_printf("%s %s",dummy2, dummy); g_free(dummy2); dummy2 = tmp; } sipmsg_add_header(msg, parts[0], dummy2); g_strfreev(parts); } g_strfreev(lines); msg->bodylen = strtol(sipmsg_find_header(msg, "Content-Length"),NULL,10); if(msg->response) { tmp = sipmsg_find_header(msg, "CSeq"); if(!tmp) { /* SHOULD NOT HAPPEN */ msg->method = 0; } else { parts = g_strsplit(tmp, " ", 2); msg->method = g_strdup(parts[1]); g_strfreev(parts); } } return msg; } void sipmsg_print(struct sipmsg *msg) { GSList *cur; struct siphdrelement *elem; gaim_debug(GAIM_DEBUG_MISC, "simple", "SIP MSG\n"); gaim_debug(GAIM_DEBUG_MISC, "simple", "response: %d\nmethod: %s\nbodylen: %d\n",msg->response,msg->method,msg->bodylen); if(msg->target) gaim_debug(GAIM_DEBUG_MISC, "simple", "target: %s\n",msg->target); cur = msg->headers; while(cur) { elem = cur->data; gaim_debug(GAIM_DEBUG_MISC, "simple", "name: %s value: %s\n",elem->name, elem->value); cur = g_slist_next(cur); } } char *sipmsg_to_string(struct sipmsg *msg) { gchar *out; gchar *old; GSList *cur; struct siphdrelement *elem; if(msg->response) out = g_strdup_printf("SIP/2.0 %d Unknown\r\n", msg->response); else out = g_strdup_printf("%s %s SIP/2.0\r\n",msg->method, msg->target); cur = msg->headers; while(cur) { elem = cur->data; old = out; out = g_strdup_printf("%s%s: %s\r\n", out, elem->name, elem->value); g_free(old); cur = g_slist_next(cur); } old = out; out = g_strdup_printf("%s\r\n",out); g_free(old); if(msg->bodylen) { old = out; out = g_strdup_printf("%s%s",out, msg->body); g_free(old); } return out; } void sipmsg_add_header(struct sipmsg *msg, gchar *name, gchar *value) { struct siphdrelement *element = g_new0(struct siphdrelement,1); element->name = g_strdup(name); element->value = g_strdup(value); msg->headers = g_slist_append(msg->headers, element); } void sipmsg_free(struct sipmsg *msg) { struct siphdrelement *elem; while(msg->headers) { elem = msg->headers->data; msg->headers = g_slist_remove(msg->headers,elem); g_free(elem->name); g_free(elem->value); g_free(elem); } if(msg->method) g_free(msg->method); if(msg->target) g_free(msg->target); if(msg->body) g_free(msg->body); g_free(msg); } void sipmsg_remove_header(struct sipmsg *msg, gchar *name) { struct siphdrelement *elem; GSList *tmp = msg->headers; while(tmp) { elem = tmp->data; if(strcmp(elem->name, name)==0) { msg->headers = g_slist_remove(msg->headers, elem); return; } tmp = g_slist_next(tmp); } return; } gchar *sipmsg_find_header(struct sipmsg *msg, gchar *name) { GSList *tmp; struct siphdrelement *elem; tmp = msg->headers; while(tmp) { elem = tmp->data; if(strcmp(elem->name,name)==0) { return elem->value; } tmp = g_slist_next(tmp); } return NULL; }
