view src/socket.c @ 7667:30593bf56e71

[gaim-migrate @ 8311] (23:56:25) shx: LSchiere: there's something wrong in my patch (23:56:34) Luke: okay (23:56:38) Luke: what's that (23:57:45) shx: I forgot to add a '0' a the end of a string (23:57:56) shx: in the gaim_mime_decode_field funcition (23:59:35) Luke: where in that? (00:00:16) shx: at the end, just before this (00:00:18) shx: if (*unencoded_start) (00:00:19) shx: n = strcpy(n, unencoded_start); (00:00:27) shx: whould be this (00:00:28) shx: *n = '\0'; (00:01:05) Luke: so you are just setting it to NULL (00:01:53) Luke: i don't understand why you need that n set at all inside that if, since you just return new on the next line down (00:03:35) shx: I doing some test right now, but I remember I added that because I had of some errors (00:05:04) Luke: i think what you may be hitting is a functional work around for not properly initializing variables, something that shouldn't work but does. because you shouldn't need to set something just before you return unless you are returning IT (or unless you are using staticly declared memory, in which case you might concievably be using that variable again when you next enter the function (00:05:55) shx: no (00:06:18) shx: n is a pointer to the end of the string, and changes as the while goes on (00:06:37) Luke: ah (00:06:42) shx: n doesn't matter (00:07:01) Luke: so should the *n = '\0' be inside the if or outside it? (00:07:30) shx: before the if (00:07:44) shx: *n = '\0'; (00:07:45) shx: if (*unencoded_start) (00:07:45) shx: n = strcpy(n, unencoded_start); (00:08:07) shx: in the case there is no *unencoded_start committer: Tailor Script <tailor@pidgin.im>
author Luke Schierer <lschiere@pidgin.im>
date Sun, 30 Nov 2003 05:10:24 +0000
parents 43e396e94095
children fa6395637e2c
line wrap: on
line source

/*
 * gaim-remote
 *
 * Copyright (C) 2002, Sean Egan <bj91704@binghamton.edu>
 * 
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
 *
 */

/* Somewhat inspired by XMMS:
 *  Copyright (C) 1998-2002  Peter Alm, Mikael Alm, Olle Hallnas,
 *                           Thomas Nilsson and 4Front Technologies
 *  Copyright (C) 1999-2002  Haavard Kvaalen 
 */
 
/* This provides code for connecting to a Gaim socket and communicating with
 * it.  It will eventually be made a library once the core and ui are split. */

#include <sys/types.h>
#include <sys/socket.h>
#include <sys/un.h>
#include <unistd.h>
#include "gaim.h"
#include "gaim-socket.h"

void cui_send_packet (int fd, struct gaim_cui_packet *p) {
	int len = sizeof(p->type) + sizeof(p->subtype) + sizeof(p->length) + p->length;
	char *pack = g_malloc(len);
	char *a = pack;
	memcpy (a, &(p->type), sizeof(p->type));
	a = a + sizeof(p->type);
	memcpy (a, &(p->subtype), sizeof(p->subtype));
	a = a + sizeof(p->subtype);
	memcpy (a, &(p->length), sizeof(p->length));
	a = a + sizeof(p->length);
	memcpy (a, p->data, p->length);
	write(fd, pack, len);
	g_free(pack);
}


void cui_packet_append_string(struct gaim_cui_packet *p, char *str) {
	int len = p->length + strlen(str);
	char *k = g_malloc(len);
	memcpy(k, p->data, p->length);
	memcpy(k + p->length, str, strlen(str));
	if (p->data)
		g_free(p->data);
	p->data = k;
	p->length = len;
}

void cui_packet_append_char(struct gaim_cui_packet *p, char c) {
	int len = p->length + sizeof(char);
	char *k = g_malloc(len);
	memcpy(k, p->data, p->length);
	k[p->length] = c;
	if (p->data)
		g_free(p->data);
	p->data = k;
	p->length = len;
}

void cui_packet_append_raw(struct gaim_cui_packet *p, char *str, int len) {
	int lent = p->length + len;
	char *k = g_malloc(lent);
	memcpy(k, p->data, p->length);
	memcpy(k + p->length, str, len);
	if (p->data)
		g_free(p->data);
	p->data = k;
	p->length = lent;
}

struct gaim_cui_packet *cui_packet_new(guchar type, guchar subtype) {
	struct gaim_cui_packet *p = g_new0(struct gaim_cui_packet, 1);
	p->type = type;
	p->subtype = subtype;
	p->length = 0;
	p->data = NULL;
	return p;
}

void cui_packet_free(struct gaim_cui_packet *p) {
	if (p->data)
		g_free(p->data);
	g_free(p);
}

struct gaim_cui_packet *cui_read_packet(int fd) {
	struct gaim_cui_packet *p = g_new0(struct gaim_cui_packet, 1);
	char *data = NULL;

	if (!(read(fd, &p->type, sizeof(p->type)))) {
		g_free(p);
		return NULL;
	}
	
	
	if (!(read(fd, &p->subtype, sizeof(p->subtype)))) {
		g_free(p);
		return NULL;
	}
	
	
	if (!(read(fd, &p->length, sizeof(p->length)))) {
		g_free(p);
		return NULL;
	}
	
	if (p->length) {
		data = g_malloc(p->length);
		if (!(read(fd, data, p->length))) {
			g_free(p);
			return NULL;
		}
	}
	p->data = data;
	return p;
}

/* copied directly from xmms_connect_to_session */
gint gaim_connect_to_session(gint session)
{
	gint fd;
	uid_t stored_uid, euid;
	struct sockaddr_un saddr;

	if ((fd = socket(AF_UNIX, SOCK_STREAM, 0)) != -1)
	{
		saddr.sun_family = AF_UNIX;
		stored_uid = getuid();
		euid = geteuid();
		setuid(euid);
		sprintf(saddr.sun_path, "%s/gaim_%s.%d", g_get_tmp_dir(), g_get_user_name(), session);
		setreuid(stored_uid, euid);
		if (connect(fd, (struct sockaddr *) &saddr, sizeof (saddr)) != -1)
			return fd;
	}
	close(fd);
	return -1;
}

gboolean gaim_session_exists(int sess)
{
	struct gaim_cui_packet *pack = NULL;

	int fd = gaim_connect_to_session(sess);
	if (fd > 0) {
		pack = cui_packet_new(CUI_TYPE_META, CUI_META_PING);
		cui_send_packet(fd, pack);
		cui_packet_free(pack);
		close(fd);
	} else {
		return FALSE;
	}
	return TRUE;
}