Mercurial > pidgin
view src/status.c @ 7667:30593bf56e71
[gaim-migrate @ 8311]
(23:56:25) shx: LSchiere: there's something wrong in my patch
(23:56:34) Luke: okay
(23:56:38) Luke: what's that
(23:57:45) shx: I forgot to add a '0' a the end of a string
(23:57:56) shx: in the gaim_mime_decode_field funcition
(23:59:35) Luke: where in that?
(00:00:16) shx: at the end, just before this
(00:00:18) shx: if (*unencoded_start)
(00:00:19) shx: n = strcpy(n, unencoded_start);
(00:00:27) shx: whould be this
(00:00:28) shx: *n = '\0';
(00:01:05) Luke: so you are just setting it to NULL
(00:01:53) Luke: i don't understand why you need that n set at all inside
that if, since you just return new on the next line down
(00:03:35) shx: I doing some test right now, but I remember I added that
because I had of some errors
(00:05:04) Luke: i think what you may be hitting is a functional work
around for not properly initializing variables, something that shouldn't
work but does. because you shouldn't need to set something just before you
return unless you are returning IT (or unless you are using staticly
declared memory, in which case you might concievably be using that variable
again when you next enter the function
(00:05:55) shx: no
(00:06:18) shx: n is a pointer to the end of the string, and changes as the
while goes on
(00:06:37) Luke: ah
(00:06:42) shx: n doesn't matter
(00:07:01) Luke: so should the *n = '\0' be inside the if or outside it?
(00:07:30) shx: before the if
(00:07:44) shx: *n = '\0';
(00:07:45) shx: if (*unencoded_start)
(00:07:45) shx: n = strcpy(n, unencoded_start);
(00:08:07) shx: in the case there is no *unencoded_start
committer: Tailor Script <tailor@pidgin.im>
| author | Luke Schierer <lschiere@pidgin.im> |
|---|---|
| date | Sun, 30 Nov 2003 05:10:24 +0000 |
| parents | 8f94cce8faa5 |
| children | fa6395637e2c |
line wrap: on
line source
/* * gaim * * Copyright (C) 2003 Jason Priestly * Copyright (C) 2003 Luke Perry * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ #include "status.h" #include "internal.h" #include "debug.h" #include "util.h" /* XXX CORE/UI */ #include "gtkinternal.h" #include "ui.h" /* for people like myself who are too lazy to add an away msg :) */ /* I don't know who "myself" is in this context. The exclamation point * makes it slightly less boring ;) */ #define BORING_DEFAULT_AWAY_MSG _("Sorry, I ran out for a bit!") /* XML File Saving */ /* All of this code is adapted from Nathan Walp's. It's adapted all over the place * for accounts, the buddy list, pounces, preferences, and the likes. It would be * neat if we could somehow make this more generic. */ static gboolean status_loaded = FALSE; static guint status_save_timer = 0; typedef enum { TAG_NONE = 0, TAG_STATUS, TAG_STATE, TAG_MESSAGE, } StatusParserTag; typedef struct { StatusParserTag tag; GString *buffer; struct away_message *am; } StatusParserData; static void free_parser_data(gpointer user_data) { StatusParserData *data = user_data; if (data->buffer != NULL) g_string_free(data->buffer, TRUE); g_free(data); } static void gaim_status_write(FILE *fp, struct away_message *am) { char *esc = NULL; esc = g_markup_escape_text(am->name, -1); fprintf(fp, "\t<status name=\"%s\">\n", esc); g_free(esc); fprintf(fp, "\t\t<state>away</state>\n"); esc = g_markup_escape_text(am->message, -1); fprintf(fp, "\t\t<message>%s</message>\n", esc); g_free(esc); fprintf(fp, "\t</status>\n"); } static gboolean status_save_cb(gpointer unused) { gaim_status_sync(); status_save_timer = 0; return FALSE; } static void schedule_status_save() { if (!status_save_timer) status_save_timer = g_timeout_add(5000, status_save_cb, NULL); } static void start_element_handler(GMarkupParseContext *context, const gchar *element_name, const gchar **attribute_names, const gchar **attribute_values, gpointer user_data, GError **error) { const char *value; StatusParserData *data = user_data; GHashTable *atts; int i; atts = g_hash_table_new_full(g_str_hash, g_str_equal, g_free, g_free); for (i = 0; attribute_names[i] != NULL; i++) { g_hash_table_insert(atts, g_strdup(attribute_names[i]), g_strdup(attribute_values[i])); } if (data->buffer != NULL) { g_string_free(data->buffer, TRUE); data->buffer = NULL; } if (!strcmp(element_name, "status")) { data->tag = TAG_STATUS; if ((value = g_hash_table_lookup(atts, "name")) != NULL) { data->am = g_new0(struct away_message, 1); g_snprintf(data->am->name, sizeof(data->am->name), "%s", value); away_messages = g_slist_append(away_messages, data->am); } } else if (!strcmp(element_name, "message")) { data->tag = TAG_MESSAGE; } g_hash_table_destroy(atts); } static void end_element_handler(GMarkupParseContext *context, const gchar *element_name, gpointer user_data, GError **error) { StatusParserData *data = user_data; gchar *buffer; if (data->buffer == NULL) return; buffer = g_string_free(data->buffer, FALSE); data->buffer = NULL; if (data->tag == TAG_MESSAGE) { if (*buffer != '\0') g_snprintf(data->am->message, sizeof(data->am->message), "%s", buffer); } data->tag = TAG_NONE; g_free(buffer); } static void text_handler(GMarkupParseContext *context, const gchar *text, gsize text_len, gpointer user_data, GError **error) { StatusParserData *data = user_data; if (data->buffer == NULL) data->buffer = g_string_new_len(text, text_len); else g_string_append_len(data->buffer, text, text_len); } static GMarkupParser status_parser = { start_element_handler, end_element_handler, text_handler, NULL, NULL }; void gaim_status_sync() { FILE *fp; const char *user_dir = gaim_user_dir(); char *filename, *filename_real; if (!status_loaded) { gaim_debug(GAIM_DEBUG_WARNING, "status", "Writing status to disk.\n"); schedule_status_save(); return; } if (user_dir == NULL) return; gaim_debug(GAIM_DEBUG_INFO, "status", "Saving statuses to disk\n"); fp = fopen(user_dir, "r"); if (fp == NULL) mkdir(user_dir, S_IRUSR | S_IWUSR | S_IXUSR); else fclose(fp); filename = g_build_filename(user_dir, "status.xml.save", NULL); if ((fp = fopen(filename, "w")) != NULL) { GSList *l; fprintf(fp, "<?xml version='1.0' encoding='UTF-8' ?>\n\n"); fprintf(fp, "<statuses>\n"); for (l = away_messages; l != NULL; l = l->next) gaim_status_write(fp, l->data); fprintf(fp, "</statuses>\n"); fclose(fp); chmod(filename, S_IRUSR | S_IWUSR); } else { gaim_debug(GAIM_DEBUG_ERROR, "status", "Unable to write %s\n", filename); } filename_real = g_build_filename(user_dir, "status.xml", NULL); if (rename(filename, filename_real) < 0) { gaim_debug(GAIM_DEBUG_ERROR, "status", "Error renaming %s to %s\n", filename, filename_real); } g_free(filename); g_free(filename_real); } void gaim_status_load() { gchar *filename = g_build_filename(gaim_user_dir(), "status.xml", NULL); gchar *contents = NULL; gsize length; GMarkupParseContext *context; GError *error = NULL; StatusParserData *parser_data; if (filename == NULL) { status_loaded = TRUE; return; } if (!g_file_get_contents(filename, &contents, &length, &error)) { gaim_debug(GAIM_DEBUG_ERROR, "status", "Error reading statuses: %s\n", error->message); g_error_free(error); g_free(filename); status_loaded = TRUE; if (!away_messages) { struct away_message *a = g_new0(struct away_message, 1); g_snprintf(a->name, sizeof(a->name), _("Slightly less boring default")); g_snprintf(a->message, sizeof(a->message), "%s", _(BORING_DEFAULT_AWAY_MSG)); away_messages = g_slist_append(away_messages, a); } return; } parser_data = g_new0(StatusParserData, 1); context = g_markup_parse_context_new(&status_parser, 0, parser_data, free_parser_data); if (!g_markup_parse_context_parse(context, contents, length, NULL)) { g_markup_parse_context_free(context); g_free(contents); g_free(filename); status_loaded = TRUE; return; } if (!g_markup_parse_context_end_parse(context, NULL)) { gaim_debug(GAIM_DEBUG_ERROR, "status", "Error parsing %s\n", filename); g_markup_parse_context_free(context); g_free(contents); g_free(filename); status_loaded = TRUE; return; } g_markup_parse_context_free(context); g_free(contents); g_free(filename); status_loaded = TRUE; return; }
