Mercurial > pidgin
view src/protocols/msn/error.h @ 10039:cf02e7104706
[gaim-migrate @ 10998]
A patch from rian hunter (chrono86):
In src/protocols/oscar/oscar.c, in the function
gaim_plugin_oscar_convert_to_best_encoding. g_convert
is called multiple times. As its 5th argument g_convert
takes a gsize* (8 byte), yet the argument to
gaim_plugin_oscar_convert_to_best_encoding is a int* (4
byte).
On LP64 machines this can allow the int* to be
overwritten. This is especially bad on big endian
64-bit machines, causing the high 32-bits to be written
into the low 32-bits of the int.
This is a quick fix patch that lets g_convert deal with
a gsize* pointer instead, then casting the value at
gsize* to the value at the int*.
A real fix would be to fix the aim_sendimext_args
structure to have a gsize instead of an int (and all
functions that use the aim_sendimext_args struct), and
changing gaim_plugin_oscar_convert_to_best_encoding to
accept a gsize*. of course, this woudl promote glib2
dependence, so that's probably not the best thing to do.
committer: Tailor Script <tailor@pidgin.im>
| author | Mark Doliner <mark@kingant.net> |
|---|---|
| date | Sat, 18 Sep 2004 23:17:18 +0000 |
| parents | ab6636c5a136 |
| children | bcfea6c3d5c9 |
line wrap: on
line source
/** * @file error.h Error functions * * gaim * * Gaim is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ #ifndef _MSN_ERROR_H_ #define _MSN_ERROR_H_ typedef enum { MSN_ERROR_NONE, MSN_ERROR_MISC, MSN_ERROR_CONNECT, MSN_ERROR_WRITE, MSN_ERROR_READ, MSN_ERROR_SIGNOTHER, MSN_ERROR_SERVDOWN } MsnErrorType; #include "session.h" /** * Returns the string representation of an error type. * * @param type The error type. * * @return The string representation of the error type. */ const char *msn_error_get_text(unsigned int type); /** * Handles an error. * * @param session The current session. * @param type The error type. */ void msn_error_handle(MsnSession *session, unsigned int type); #endif /* _MSN_ERROR_H_ */
