Mercurial > pidgin
view src/debug.c @ 12601:e63fb8e9f4ac
[gaim-migrate @ 14935]
Jason LeBrun wrote to gaim-devel:
"I have found a small quirk in the way gdk_pixbuf_loader works. When you
are using it without signalling, the proper way to use it is to call
gdk_pixbuf_loader_close *before* calling gdk_pixbuf_loader_get_animation
or gdk_pixbuf_loader_get_pixbuf. The call to gdk_pixbuf_loader_close
signals that no more writes will be occuring.
In particular, this affects images that are less than 1k in size. If
gdk_pixbuf_loader_close is not called before _get_animation, the loader
will not return anything unless it has received more than 1k of data
(the file type sniffing buffer size) or it has been closed.
So, the proper order of calls for loaders in the gtk*.c code is:
gdk_pixbuf_loader_new();
gdk_pixbuf_loader_write();
gdk_pixbuf_loader_close();
gdk_pixbuf_loader_get_animation();"
I know we fixed a bug by changing this in one place. I've gone through and updated the rest.
committer: Tailor Script <tailor@pidgin.im>
| author | Richard Laager <rlaager@wiktel.com> |
|---|---|
| date | Wed, 21 Dec 2005 18:43:39 +0000 |
| parents | 921f64947cad |
| children | e1e5462b7d81 |
line wrap: on
line source
/** * @file debug.c Debug API * @ingroup core * * gaim * * Gaim is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ #include "debug.h" #include "internal.h" #include "prefs.h" static GaimDebugUiOps *debug_ui_ops = NULL; /* * This determines whether debug info should be written to the * console or not. * * It doesn't make sense to make this a normal Gaim preference * because it's a command line option. This will always be FALSE, * unless the user explicitly started Gaim with the -d flag. * It doesn't matter what this value was the last time Gaim was * started, so it doesn't make sense to save it in prefs. */ static gboolean debug_enabled = FALSE; static void gaim_debug_vargs(GaimDebugLevel level, const char *category, const char *format, va_list args) { GaimDebugUiOps *ops; g_return_if_fail(level != GAIM_DEBUG_ALL); g_return_if_fail(format != NULL); if (debug_enabled) { gchar *arg_s, *ts_s; arg_s = g_strdup_vprintf(format, args); if ((category != NULL) && (gaim_prefs_exists("/core/debug/timestamps")) && (gaim_prefs_get_bool("/core/debug/timestamps"))) { gchar mdate[64]; time_t mtime = time(NULL); strftime(mdate, sizeof(mdate), "%H:%M:%S", localtime(&mtime)); ts_s = g_strdup_printf("(%s) ", mdate); } else { ts_s = g_strdup(""); } if (category == NULL) g_print("%s%s", ts_s, arg_s); else g_print("%s%s: %s", ts_s, category, arg_s); g_free(arg_s); g_free(ts_s); } ops = gaim_debug_get_ui_ops(); if (ops != NULL && ops->print != NULL) ops->print(level, category, format, args); } void gaim_debug(GaimDebugLevel level, const char *category, const char *format, ...) { va_list args; g_return_if_fail(level != GAIM_DEBUG_ALL); g_return_if_fail(format != NULL); va_start(args, format); gaim_debug_vargs(level, category, format, args); va_end(args); } void gaim_debug_misc(const char *category, const char *format, ...) { va_list args; g_return_if_fail(format != NULL); va_start(args, format); gaim_debug_vargs(GAIM_DEBUG_MISC, category, format, args); va_end(args); } void gaim_debug_info(const char *category, const char *format, ...) { va_list args; g_return_if_fail(format != NULL); va_start(args, format); gaim_debug_vargs(GAIM_DEBUG_INFO, category, format, args); va_end(args); } void gaim_debug_warning(const char *category, const char *format, ...) { va_list args; g_return_if_fail(format != NULL); va_start(args, format); gaim_debug_vargs(GAIM_DEBUG_WARNING, category, format, args); va_end(args); } void gaim_debug_error(const char *category, const char *format, ...) { va_list args; g_return_if_fail(format != NULL); va_start(args, format); gaim_debug_vargs(GAIM_DEBUG_ERROR, category, format, args); va_end(args); } void gaim_debug_fatal(const char *category, const char *format, ...) { va_list args; g_return_if_fail(format != NULL); va_start(args, format); gaim_debug_vargs(GAIM_DEBUG_FATAL, category, format, args); va_end(args); } void gaim_debug_set_enabled(gboolean enabled) { debug_enabled = enabled; } gboolean gaim_debug_is_enabled() { return debug_enabled; } void gaim_debug_set_ui_ops(GaimDebugUiOps *ops) { debug_ui_ops = ops; } GaimDebugUiOps * gaim_debug_get_ui_ops(void) { return debug_ui_ops; } void gaim_debug_init(void) { gaim_prefs_add_none("/core/debug"); /* * This pref is currently used by both the console * output and the debug window output. */ gaim_prefs_add_bool("/core/debug/timestamps", FALSE); }
