Mercurial > pidgin
view src/stringref.h @ 9584:fe35f55ee984
[gaim-migrate @ 10427]
" When joining a jabber conference many jabber servers
send a recap of the last 20 or so messages. If you
have sounds enabled, this will result in either 20
sounds in row, or worse if mixing is available, a
horrible mix of 20 overlapping sounds. These recap
messages can be identifed be the presence of the
"jabber:x:delay". This patch identifies delayed
messages, passes that information through flags from
the prpl to the core, and then on to the gui. Detailed
changes:
Add GAIM_MESSAGE_DELAYED to GaimMessageFlags to
indicate a delayed message.
Change gtkconv.c to not play sounds when either
GAIM_MESSAGE_DELAYED or GAIM_MESSAGE_SYSTEM are set.
Add GaimConvChatFlags, parallel to GaimConvImFlags, to
pass flags from protocols to core. Currently contains
two flags:
GAIM_CONV_CHAT_WHISPER
GAIM_CONV_CHAT_DELAYED
Change fourth arg of serv_got_chat_in() from "int
whisper" to "GaimConvChatFlags chatflags".
Change jabber prpl to set delayed flag when the
"jabber:x:delay" element is present. Change toc
protocol since it uses the whisper flag." --Nathan Fredrickson
Date: 2004-07-24 00:49
Sender: marv_sfAccepting Donations
Logged In: YES
user_id=790708
I'm not sure I like naming the flags "DELAYED". I mean
that's okay inside jabber since that's what the jabber
protocol refers to it as, but for the the GAIM_*_DELAYED
flags, I think they should be named something else.
I thought about NOSOUND, but I decided that was wrong,
because the flag should say what kind of message it is, not
what to do with it, that's up to the UI to decide.
What's up with not playing sounds on GAIM_MESSAGE_SYSTEM?
This sounds unrelated to this. Are there times when we want
to play sounds on system messages?
Date: 2004-07-24 09:13
Sender: noif
Logged In: YES
user_id=365548
I purposely did not use a name that implied what the UI
should do with the flag. The only characteristic that makes
these messages unique is that they've been stored in the
server for some period of time and are not current. I'm
open to a better flag name than "DELAYED"... I thought about
"RECAP", but that seemed less generalized than "DELAYED".
As for not playing sounds on GAIM_MESSAGE_SYSTEM, that can
be removed if it's controversial. I think I slipped that
in since the setting of the topic was still playing a sound
every time you joined a jabber conference.
I think we can change the flag name ourselves if something else is better.
committer: Tailor Script <tailor@pidgin.im>
| author | Luke Schierer <lschiere@pidgin.im> |
|---|---|
| date | Sat, 24 Jul 2004 15:18:32 +0000 |
| parents | ceb88c0a1abb |
| children | db62420a53a2 |
line wrap: on
line source
/** * @file stringref.h Reference-counted immutable strings * @ingroup core * * gaim * * Gaim is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA * */ #ifndef _GAIM_STRINGREF_H_ #define _GAIM_STRINGREF_H_ /** * The internal representation of a stringref. * * @note For this structure to be useful, the string contained within * it must be immutable -- for this reason, do _not_ access it * directly! */ typedef struct _GaimStringref { guint32 ref; /**< The reference count of this string. * Note that reference counts are only * 31 bits, and the high-order bit * indicates whether this string is up * for GC at the next idle handler... * But you aren't going to touch this * anyway, right? */ char value[1]; /**< The string contained in this ref. * Notice that it is simply "hanging * off the end" of the ref ... this * is to save an allocation. */ } GaimStringref; /** * Creates an immutable reference-counted string object. The newly * created object will have a reference count of 1. * * @param value This will be the value of the string; it will be * duplicated. * * @return A newly allocated string reference object with a refcount * of 1. */ GaimStringref *gaim_stringref_new(const char *value); /** * Creates an immutable reference-counted string object. The newly * created object will have a reference count of zero, and if it is * not referenced before the next iteration of the mainloop it will * be freed at that time. * * @param value This will be the value of the string; it will be * duplicated. * * @return A newly allocated string reference object with a refcount * of zero. */ GaimStringref *gaim_stringref_new_noref(const char *value); /** * Creates an immutable reference-counted string object from a printf * format specification and arguments. The created object will have a * reference count of 1. * * @param format A printf-style format specification. * * @return A newly allocated string reference object with a refcount * of 1. */ GaimStringref *gaim_stringref_printf(const char *format, ...); /** * Increase the reference count of the given stringref. * * @param stringref String to be referenced. * * @return A pointer to the referenced string. */ GaimStringref *gaim_stringref_ref(GaimStringref *stringref); /** * Decrease the reference count of the given stringref. If this * reference count reaches zero, the stringref will be freed; thus * you MUST NOT use this string after dereferencing it. * * @param stringref String to be dereferenced. */ void gaim_stringref_unref(GaimStringref *stringref); /** * Retrieve the value of a stringref. * * @note This value should not be cached or stored in a local variable. * While there is nothing inherently incorrect about doing so, it * is easy to forget that the cached value is in fact a * reference-counted object and accidentally use it after * dereferencing. This is more problematic for a reference- * counted object than a heap-allocated object, as it may seem to * be valid or invalid nondeterministically based on how many * other references to it exist. * * @param stringref String reference from which to retrieve the value. * * @return The contents of the string reference. */ const char *gaim_stringref_value(const GaimStringref *stringref); /** * Compare two stringrefs for string equality. This returns the same * value as strcmp would, where <0 indicates that s1 is "less than" s2 * in the ASCII lexicography, 0 indicates equality, etc. * * @param s1 The reference string. * * @param s2 The string to compare against the reference. * * @return An ordering indication on s1 and s2. */ int gaim_stringref_cmp(const GaimStringref *s1, const GaimStringref *s2); /** * Find the length of the string inside a stringref. * * @param stringref The string in whose length we are interested. * * @return The length of the string in stringref */ size_t gaim_stringref_len(const GaimStringref *stringref); #endif /* _GAIM_STRINGREF_H_ */
