# HG changeset patch # User Elliott Sales de Andrade # Date 1327731621 0 # Node ID 3967a194cb4eef84d185bca4905a6286e88b87c4 # Parent bc0d1855223f4379a3f0fe93a413f1f437678ca5 This extra if-level can be dropped. diff -r bc0d1855223f -r 3967a194cb4e libpurple/protocols/msn/oim.c --- a/libpurple/protocols/msn/oim.c Sat Jan 28 06:19:17 2012 +0000 +++ b/libpurple/protocols/msn/oim.c Sat Jan 28 06:20:21 2012 +0000 @@ -676,29 +676,27 @@ g_free(decode_msg); - } else { - if (!g_utf8_validate(decode_msg, body_len, NULL)) { - char *clean = purple_utf8_salvage(decode_msg); + } else if (!g_utf8_validate(decode_msg, body_len, NULL)) { + char *clean = purple_utf8_salvage(decode_msg); - purple_debug_error("msn", "Received an OIM message that is not UTF-8," - " and no encoding specified: %s\n", clean); + purple_debug_error("msn", "Received an OIM message that is not UTF-8," + " and no encoding specified: %s\n", clean); - if (charset) { - clean_msg = g_strdup_printf(_("%s (There was an error receiving this message." - " The charset was %s, but it was not valid UTF-8.)"), - clean, charset); - } else { - clean_msg = g_strdup_printf(_("%s (There was an error receiving this message." - " The charset was missing, but it was not valid UTF-8.)"), - clean); - } + if (charset) { + clean_msg = g_strdup_printf(_("%s (There was an error receiving this message." + " The charset was %s, but it was not valid UTF-8.)"), + clean, charset); + } else { + clean_msg = g_strdup_printf(_("%s (There was an error receiving this message." + " The charset was missing, but it was not valid UTF-8.)"), + clean); + } - g_free(clean); - g_free(decode_msg); + g_free(clean); + g_free(decode_msg); - } else { - clean_msg = decode_msg; - } + } else { + clean_msg = decode_msg; } from = msn_message_get_header_value(message, "X-OIM-originatingSource");