Mercurial > audlegacy-plugins
changeset 655:6a656a7f40fa trunk
[svn] - fix double free bug in vorbis fileinfo.
| author | yaz |
|---|---|
| date | Thu, 15 Feb 2007 17:04:00 -0800 |
| parents | 8bd5fae12b9c |
| children | 3d734efe82d0 |
| files | ChangeLog src/vorbis/fileinfo.c src/vorbis/vorbis.c |
| diffstat | 3 files changed, 11 insertions(+), 2 deletions(-) [+] |
line wrap: on
line diff
--- a/ChangeLog Thu Feb 15 15:18:39 2007 -0800 +++ b/ChangeLog Thu Feb 15 17:04:00 2007 -0800 @@ -1,3 +1,12 @@ +2007-02-15 23:18:39 +0000 Michael Farber <01mf02@gmail.com> + revision [1394] + - adapted to new INI routines + + + trunk/src/pls/pls.c | 56 ++++++++++++++++++++++++++++------------------------ + 1 file changed, 31 insertions(+), 25 deletions(-) + + 2007-02-15 13:10:08 +0000 Giacomo Lozito <james@develia.org> revision [1392] - madplug: check that text is not null before using g_strtod
--- a/src/vorbis/fileinfo.c Thu Feb 15 15:18:39 2007 -0800 +++ b/src/vorbis/fileinfo.c Thu Feb 15 17:04:00 2007 -0800 @@ -1071,5 +1071,5 @@ gtk_widget_set_sensitive(save_button, FALSE); gtk_widget_set_sensitive(remove_button, FALSE); - g_free(fh); + g_free(fh); // see vorbis.c ovcb_close() --yaz }
--- a/src/vorbis/vorbis.c Thu Feb 15 15:18:39 2007 -0800 +++ b/src/vorbis/vorbis.c Thu Feb 15 17:04:00 2007 -0800 @@ -1024,7 +1024,7 @@ if (handle->probe == FALSE) { ret = vfs_fclose(handle->fd); - g_free(handle); +// g_free(handle); // it causes double free. i'm not really sure that commenting out at here is correct. --yaz } return ret;