Mercurial > audlegacy
changeset 2400:4daf4fa409e0 trunk
[svn] - make a note that hashtable collisions in the plugin matrix are not
only possible, but happening, and have strange side effects.
| author | nenolod |
|---|---|
| date | Thu, 25 Jan 2007 01:52:51 -0800 |
| parents | 9b7b11176d4e |
| children | c4c24ca99c31 |
| files | ChangeLog src/audacious/pluginenum.c |
| diffstat | 2 files changed, 14 insertions(+), 0 deletions(-) [+] |
line wrap: on
line diff
--- a/ChangeLog Wed Jan 24 18:40:07 2007 -0800 +++ b/ChangeLog Thu Jan 25 01:52:51 2007 -0800 @@ -1,3 +1,11 @@ +2007-01-25 02:40:07 +0000 Yoshiki Yazawa <yaz@cc.rim.or.jp> + revision [3808] + - should not pass null fd to input plugins. + + trunk/src/audacious/input.c | 3 +++ + 1 file changed, 3 insertions(+) + + 2007-01-24 23:15:46 +0000 Derek Pomery <nemo@m8y.org> revision [3806] Strip 0xFEFF
--- a/src/audacious/pluginenum.c Wed Jan 24 18:40:07 2007 -0800 +++ b/src/audacious/pluginenum.c Thu Jan 25 01:52:51 2007 -0800 @@ -277,6 +277,12 @@ return; } + /* + * FIXME: this collides in many cases. this is really bad. + * i have no idea why we use a hashtable here, there is no point, when + * a list of enabled plugins would realistically offer the same + * scalability. - nenolod + */ plugin_matrix = g_hash_table_new_full(g_str_hash, g_int_equal, g_free, NULL);